Repository navigation
Commit bc703d9
fix: Read naive datetimes as UTC in UnixTimestamp values
Converting a naive datetime.datetime to a UnixTimestamp value called
datetime.timestamp(), which reads a naive value in the machine's local
timezone. A naive pd.Timestamp or np.datetime64 is read as UTC, as is a
naive ZonedTimestamp, and Feast treats naive datetimes as UTC elsewhere
(make_tzaware). So the same wall-clock value was stored at a different
instant depending on its Python type and on the host timezone, e.g. a
naive request timestamp passed to get_online_features came back shifted
by the server's UTC offset.
Attach UTC to naive datetimes before taking the timestamp. This covers
UnixTimestamp scalars, lists and sets.
Signed-off-by: Mohammad Hijjawi <[email protected]>1 parent 6259f5c commit bc703d9
2 files changed
Lines changed: 41 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
725 | 725 | | |
726 | 726 | | |
727 | 727 | | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
728 | 732 | | |
729 | 733 | | |
730 | 734 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
| 5 | + | |
4 | 6 | | |
5 | 7 | | |
6 | 8 | | |
| |||
53 | 55 | | |
54 | 56 | | |
55 | 57 | | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
56 | 93 | | |
57 | 94 | | |
58 | 95 | | |
| |||
0 commit comments