-
Notifications
You must be signed in to change notification settings - Fork 186
Consider bumping the minimum Python version #1190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
... since that is what all of our systems use and test with now.
... as that is what all systems and tests run on now.
|
For reference on making Python 3.7 minimum supported version: pyproj4/pyproj#790 |
Codecov Report
@@ Coverage Diff @@
## develop #1190 +/- ##
========================================
Coverage 93.75% 93.75%
========================================
Files 102 102
Lines 10352 10352
========================================
Hits 9705 9705
Misses 647 647 Continue to review full report at Codecov.
|
Kirill888
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no issues with this change.
We currently run tests with 3.8 only, but I guess we "test" 3.6 in sandbox, which will hopefully soon switch to 3.8 too.
omad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with deprecating 3.6 support and skipping 3.7.
NCI and DEA Sandbox are both still running 3.6, but are both long overdue for an update.
|
It's also good timing soon after a release. We should bump to 1.9.0 for the next release. |
|
@woodcockr EASI is using Python 3.8 already isn't? |
|
Sandbox images are now working in DE Africa with Python 3.8 and it seems fine. |
I think part of the previous difficulty was because the DEA code had a dependency that was strictly python3.6-only. I have a PR to move it: GeoscienceAustralia/digitalearthau#305 |
|
@Kirill888 Yep, EASI is on Python 3.8 already and everything we use it working fine. Thank you for asking. |
This PR may be controversial, but I noticed our Docker container now uses Python 3.8, and hence all of our tests are now only running on Python 3.8 (from what I can see?).
My experience is that it's very easy to break 3.6 support by accident if not testing with it. And we're increasingly seeing dependencies drop support for 3.6 on other repositories in the ODC ecosystem.
Some options:
I'm happy to remove the second commit if people think it's too harsh. But I think a minimum requirement is friendlier to users than exposing people to unexpected bugs.
Thoughts?
ps. The other option, of course, it to make 3.7 the minimum. But is that still common anywhere, among non-Docker users? And do we want to test with it?
pps. I also bumped the Postgres version recommendation, since none of us test on 9.5. But there's no hard requirement.