Closed
Conversation
Contributor
paroj
commented
Apr 7, 2015
paroj
commented
- move label validation out of inner loop
- remove manual loop unrolling - the compiler is better at this
- use functions/ enums instead of macros/ defines
* remove manual loop unrolling - the compiler is better at this * use functions/ enums instead of macros/ defines
Contributor
|
@paroj, thanks for the patch, but we can not accept it, it includes just a few questionable changes and that's it |
Contributor
Author
|
feel free to ask about what you think is questionable. the changes (slightly) improve performance and make the code more maintainable (no custom MAX, no old style define) |
Contributor
Author
|
note that both the unrolled and not unrolled version of the loop is unrolled to 8 and vectorized by gcc 4.8. However it fails to detect the loop invariant (iter == 0 && a == 0) and thus checks for this in each loop iteration.. |
mshabunin
pushed a commit
to mshabunin/opencv
that referenced
this pull request
Aug 25, 2015
…y OR'ed instead of added. Conflicts: modules/features2d/src/draw.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.