Conversation
|
Also, I'd like to suggest updating of this help page http://code.opencv.org/projects/opencv/wiki/HowToUsePerfTests with the following: <...> Usage exapmles: This copies tests binaries and CMakeCache.txt (run.py make use of this file) and also updates CMakeCache.txt with the proper binaries path |
|
Hi, could you please to look into the build failure described below? Received Docs build failure while build portal was unavailable on the web. Failure step: "Merge opencv with test branch"; Link Logs: "fatal: unable to access 'https://github.com/MSOpenTech/opencv.git/': SSLRead() return error -9806"; Link Was it portal or git failure? If so, could you please restart the build? |
c29e207 to
65aec5c
Compare
|
Updating of the PR triggered rebuild and builds are green now |
|
👍 |
modules/ts/misc/run.py
Outdated
There was a problem hiding this comment.
build_path is still optional parameter with '.' default value (script is lauched from the binary directory). So please keep [build_path] in help descriptions.
There was a problem hiding this comment.
@alalek However, it is not obvious and such help message may be confusing for user who is not familiar with run.py code when he is starting script from location other then binary directory
|
General note: |
|
@alalek In case of using install directory out of OCV build structure (no CMakeCache.txt on the upper levels) run.py cannot start the tests. |
--help message and starting run.py w/o parameters generate different messages E. g. w/ and w/o build_path in the end build_path is required, removing square brackets
d7f56ec to
14346eb
Compare
|
ABI incompatibility looks the same as we had here |
modules/ts/misc/run.py
Outdated
There was a problem hiding this comment.
I believe that error message is missed here (like "Specify build_path or run script from CMake build directory")
There was a problem hiding this comment.
@alalek Updated this part and OptionParser message with details concerning of the build_path
|
Right, |
This allows to start run.py with --move_tests parameter to place tests to another location and keep them runnable from there
14346eb to
ae090fe
Compare
|
Thanks! |
Fixed doc for Bug opencv#3887
Fixing help messages
Message shown by the --help option and message shown while starting run.py w/o (or with wrong) parameters are different, e. g. w/ and w/o "[build_path]" in the end. As "build_path" is required, removing square brackets.
Extending functionality:
Developer may wish to back up some test binaries to compare their behavior with modified version later or just pass current version to QA team.
Expected: can start from backed up sources using run.py script
Actual: run.py looks for an old binaries path from CMakeCache.txt and tests are used from the old location (if exists)
Adding of --move_tests option allows to specify new location, create back up and run tests from it. Command line should look like the following:
>> run.py --move_tests "new location" "current location"This command copies test binaries and CMakeCache.txt file (that file is required by the script) and updates CMakeCache.txt with a new binaries path value.
After that you may start run.py for the new location with "Expected" result