ocl: Change static variable order in cl_context.cpp to avoid crashes dur...#3337
Merged
opencv-pushbot merged 1 commit intoopencv:2.4from Oct 16, 2014
tstellarAMD:2.4-ocl-context-cleanup-fix
Merged
ocl: Change static variable order in cl_context.cpp to avoid crashes dur...#3337opencv-pushbot merged 1 commit intoopencv:2.4from tstellarAMD:2.4-ocl-context-cleanup-fix
opencv-pushbot merged 1 commit intoopencv:2.4from
tstellarAMD:2.4-ocl-context-cleanup-fix
Conversation
…during destruction ContextImpl::currentContext contains a reference to one of the DeviceInfoImpl objects from: static std::vector<DeviceInfoImpl> global_devices; ContextImpl::currentContext is destroyed in the destructor for the statically defined object __module, and relies on its DeviceInfoImpl reference to query some hardware features while being destroyed. This means that we need to ensure that the global_devices vector is destroyed affter __module, otherwise ContextImpl::currentContext's DeviceInfoImpl reference will no longer be valid when __module is destroyed. Since these variables are all confined to a single compilation unit, they will be destruct from bottom to top, so we need to make sure that __module is the bottom definition so it can be destroyed first.
Member
|
👍 |
vpisarev
added a commit
that referenced
this pull request
Oct 16, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...ing destruction
ContextImpl::currentContext contains a reference to one of the
DeviceInfoImpl objects from:
static std::vector global_devices;
ContextImpl::currentContext is destroyed in the destructor
for the statically defined object __module, and relies on its
DeviceInfoImpl reference to query some hardware features while
being destroyed.
This means that we need to ensure that the global_devices vector is
destroyed affter __module, otherwise ContextImpl::currentContext's
DeviceInfoImpl reference will no longer be valid when __module is
destroyed.
Since these variables are all confined to a single compilation unit,
they will be destructed from bottom to top, so we need to make sure
that __module is the bottom definition so it can be destroyed first.