modules/core: fix x86 PIC code compilation#3331
Merged
opencv-pushbot merged 1 commit intoopencv:2.4from Oct 12, 2014
Merged
Conversation
This bug was triggered by Buildroot autobuilders [1,2], causing this kind of failures [3,4]: [ 14%] Building CXX object modules/core/CMakeFiles/opencv_core.dir/src/system.cpp.o /home/test/autobuild/instance-0/output/build/opencv-2.4.10/modules/core/src/system.cpp: In function '(static initializers for /home/test/autobuild/instance-0/output/build/opencv-2.4.10/modules/core/src/system.cpp)': /home/test/autobuild/instance-0/output/build/opencv-2.4.10/modules/core/src/system.cpp:280:10: error: inconsistent operand constraints in an 'asm' make[3]: *** [modules/core/CMakeFiles/opencv_core.dir/src/system.cpp.o] Error 1 [1] http://buildroot.org/ [2] http://autobuild.buildroot.org/ [3] http://autobuild.buildroot.org/?reason=opencv-2.4.10 [4] http://autobuild.buildroot.org/results/483/4838285b25d6293a5cf0bb9eadd5040a7c75d766/build-end.log Signed-off-by: Samuel Martin <[email protected]>
Contributor
|
👍 |
vpisarev
added a commit
that referenced
this pull request
Oct 12, 2014
vstehle
pushed a commit
to vstehle/buildroot
that referenced
this pull request
Oct 12, 2014
This change adds a patch fixing some opencv asm causing build failures on i*86 with PIC. This patch has been sent upstream [1]. Fixes: http://autobuild.buildroot.org/results/483/4838285b25d6293a5cf0bb9eadd5040a7c75d766/ http://autobuild.buildroot.org/?reason=opencv-2.4.10&&arch=i686 [1] opencv/opencv#3331 Signed-off-by: Samuel Martin <[email protected]> Signed-off-by: Peter Korsgaard <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes HW detection code on x86 when building PIC code.
In this case, "=b" cannot be used for output registers because ebx is used to store the GOT.
This bug is only on the 2.4 branch, and does not affect the master branch.