Skip to content

Fix for Bug #3634 and #3112#3309

Merged
opencv-pushbot merged 1 commit intoopencv:2.4from
nisargthakkar:Thickness1NoLineCV_AA
Oct 9, 2014
Merged

Fix for Bug #3634 and #3112#3309
opencv-pushbot merged 1 commit intoopencv:2.4from
nisargthakkar:Thickness1NoLineCV_AA

Conversation

@nisargthakkar
Copy link
Copy Markdown
Contributor

@nisargthakkar nisargthakkar commented Oct 6, 2014

Is the thickness <= 1 there for some reason or is it a bug?

@nisargthakkar
Copy link
Copy Markdown
Contributor Author

nisargthakkar commented Oct 7, 2014

Is there any way to log data in functions?

@ilya-lavrenov
Copy link
Copy Markdown
Contributor

ilya-lavrenov commented Oct 7, 2014

looks like your patch isn't correct since some test failed http://pullrequest.opencv.org/buildbot/builders/precommit_linux64/builds/1469

@nisargthakkar
Copy link
Copy Markdown
Contributor Author

nisargthakkar commented Oct 7, 2014

@ilya-lavrenov Yea i'm looking into it.

@mshabunin
Copy link
Copy Markdown
Contributor

mshabunin commented Oct 7, 2014

Expected image:
1
Actual image:
2

[ RUN      ] Imgproc_FindContours.accuracy
/home/maksim/work/opencv_24/modules/ts/src/ts.cpp:519: Failure
Failed

    failure reason: Bad accuracy
    test case #4
    seed: e2cc9eede63e2098
-----------------------------------
    LOG: Comparing contour outline vs manually produced edge map: Too big difference (=255) at (0, 134)
[  FAILED  ] Imgproc_FindContours.accuracy (2 ms)

This is one of failed tests.

@nisargthakkar nisargthakkar changed the title Fix for Bug #3634 Fix for Bug #3634 and #3112 Oct 8, 2014
@nisargthakkar
Copy link
Copy Markdown
Contributor Author

nisargthakkar commented Oct 8, 2014

@vpisarev, @ilya-lavrenov Can you queue the build again?

@vpisarev
Copy link
Copy Markdown
Contributor

vpisarev commented Oct 9, 2014

ok, it now looks good! thank you for the contribution! 👍

@opencv-pushbot opencv-pushbot merged commit 474897f into opencv:2.4 Oct 9, 2014
vpisarev added a commit that referenced this pull request Oct 9, 2014
@vpisarev
Merge pull request #3309 from nisargthakkar:Thickness1NoLineCV_AA
1e744bf
@nisargthakkar nisargthakkar deleted the Thickness1NoLineCV_AA branch January 8, 2015 09:12
@nisargthakkar nisargthakkar mentioned this pull request Feb 21, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vpisarev vpisarev

Labels

port/backport done Label for maintainers. Authors of PR can ignore this

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nisargthakkar @ilya-lavrenov @mshabunin @vpisarev @opencv-pushbot @alalek