Conversation
|
@vpisarev Vadim, please have a look |
modules/core/src/drawing.cpp
Outdated
There was a problem hiding this comment.
this part is duplicated twice. Can you put it into an inline function?
added Cyrillic; replace binary format with hex; move duplicated code to inline function;
a896ffe to
e9f7c4a
Compare
|
@vpisarev done |
|
Hi, @BKNio. Looks like letter |
|
Hi, @mshabunin Yep, it doesn't work, because Hershey doesn't have Ё and ё |
|
Maybe we should use |
There was a problem hiding this comment.
I believe these if must be enclosed each in other since it's more optimal
|
@mshabunin fixed |
|
Thanks, it looks better now.
For example, drawing string text = "\xC0"; // CYRILLIC CAPITAL LETTER A in CP1251 encodingcauses |
|
@BKNio, @mshabunin, so what's the decision? In my opinion, this is useful patch and we should finish it. At minimum, there should be a check whether the font contains cyrillic glyphs or not. The handling of malformed strings would be nice to have, but such a check can be added in a subsequent pull request. |
|
Let's put it in and then submit further fixes when needed. |


Added added Cyrillic support for putText and getTextSize