Skip to content

Fixes build failure on Mac OS X 10.10 beta in highgui/src/window_cocoa.mm (Bug #3737)#2908

Merged
opencv-pushbot merged 1 commit intoopencv:2.4from
mmaraya:bug_3737
Jul 7, 2014
Merged

Fixes build failure on Mac OS X 10.10 beta in highgui/src/window_cocoa.mm (Bug #3737)#2908
opencv-pushbot merged 1 commit intoopencv:2.4from
mmaraya:bug_3737

Conversation

@mmaraya
Copy link
Copy Markdown
Contributor

@mmaraya mmaraya commented Jun 27, 2014

No description provided.

@vpisarev
Copy link
Copy Markdown
Contributor

vpisarev commented Jul 1, 2014

looks like NSApplicationActivationPolicyRegular was commented off (probably for some reason) and you put it back. Can you say why it was commented off and why it can be put back now? I would not want to play game "repair in one place - break somewhere else" :)

@mmaraya
Copy link
Copy Markdown
Contributor Author

mmaraya commented Jul 3, 2014

Hi vpisarev, I checked the history of this file from 11 May 2010 to today and it appears that this has always been commented out. The value of NSApplicationActivationPolicyRegular is actually 0 and someone must have thought it was more efficient to use the value instead of a label. It appears that OS X 10.10 Yosemite Beta is now enforcing the use of the label so using the 0 literal value now causes a build failure. I've tested against OS X 10.9.3 and it compiles fine but I can't speak to older versions of OS X.

@vpisarev
Copy link
Copy Markdown
Contributor

vpisarev commented Jul 7, 2014

ok. 👍

@vpisarev vpisarev self-assigned this Jul 7, 2014
@opencv-pushbot opencv-pushbot merged commit 7936faf into opencv:2.4 Jul 7, 2014
vpisarev added a commit that referenced this pull request Jul 7, 2014
@mmaraya mmaraya deleted the bug_3737 branch July 9, 2014 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants