added missing impl for multi-dim Mat::ones, Mat::zeros ( issue #3756)#2883
Merged
opencv-pushbot merged 1 commit intoopencv:2.4from Jul 9, 2014
Merged
added missing impl for multi-dim Mat::ones, Mat::zeros ( issue #3756)#2883opencv-pushbot merged 1 commit intoopencv:2.4from
opencv-pushbot merged 1 commit intoopencv:2.4from
Conversation
Contributor
|
👍 |
|
I'd prefer to see some tests for this. |
Contributor
Author
|
appended testcase to modules/core/test/test_mat.cpp |
Contributor
|
@SpecLad, the test was added, any new questions or desires? |
|
The test itself looks fine, but I want to take another look at the main change (slightly later, though). |
|
Yeah, looks good. |
|
Except... I just merged another pull request, which makes this one fail to compile. Rebase, please. |
Contributor
Author
|
no problem, already seen this coming. last 2 buildbots did not seem to see my latest change, though |
SpecLad
pushed a commit
that referenced
this pull request
Jul 9, 2014
|
Those two don't rebuild automatically ATM. |
Contributor
Author
|
ok. thanks for your patience with this ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.