fix errors in the tutorial "Mat - The Basic Image Container"#2498
Conversation
dreamworld
commented
Mar 19, 2014
dreamworld
commented
- fix an error in sample code
- change an external link to maintain consistency with the previous tutorial
2. change an external link to maintain consistency with the previous tutorial
|
@dreamworld Thanks for PR! |
There was a problem hiding this comment.
I suggest to use here :readwriteimagevideo:imwrite() <imwrite>. readwriteimagevideo alias is defined in doc/conf.py.
There was a problem hiding this comment.
However, the alias for readwriteimagevideo seems to be not correctly interpreted, you can check this at
http://docs.opencv.org/doc/tutorials/core/mat_the_basic_image_container/mat_the_basic_image_container.html#creating-a-mat-object-explicitly
And also, in the tutorial Load, Modify, and Save an Image, imwrite() function uses alias imwrite, that's why I say to keep consistency
There was a problem hiding this comment.
I see what you mean. readWriteImageVideo is not defined, but not readwriteimagevideo. Also, there is no sense in highlighting imwrite accross the whole document, isn't it? So, please, improve "Load, Modify, and Save an Image" tutorial too (if you want, sure).
P.S. Usually, consistent must be all items started from the lowest abstraction level. In this case it's file, and proposed version satisfies it, check the copyTo() <mat-copyto> or clone() <mat-clone>, etc.
There was a problem hiding this comment.
@dreamworld Do you need any help with this? Release will be soon, so it would be good, if you can finish this request shortly. Also, we've started to print contributors in each release (http://code.opencv.org/projects/opencv/wiki/ChangeLog), so don't miss the chance to become a member of OpenCV "Hall of fame" 
1. Remove whole-document highlighting in some function links 2. fix the function alias `readwriteimagevideo`
|
@dreamworld Thanks, please, cherry-pick this commit: 22af73, from https://github.com/Daniil-Osokin/opencv/tree/fix_tutorial_mat_the_basic_image_container into your PR. I cannot do PR into your repo due to unknown reason. |
|
@Daniil-Osokin done |
|
@dreamworld Thanks for your effort! Now this tutorial looks much better! |
|
👍 |
doc/conf.py
Outdated
There was a problem hiding this comment.
As a final polishing, could you please make these lines consistent with others (like 'miscellaneous_transformations' : (, 'user_interface' : ().
There was a problem hiding this comment.
@Daniil-Osokin I didn't quite understand what you mean, could you please explain it explicitly? Thanks
There was a problem hiding this comment.
There should be spaces before colons in my changes, also I mistakenly add some extra spaces after user_interface colon. The result should be looks like this:
'miscellaneous_transformations' : ('http://docs.opencv.org/modules/imgproc/doc/miscellaneous_transformations.html#%s', None),
'user_interface' : ('http://docs.opencv.org/modules/highgui/doc/user_interface.html#%s', None),
|
Great, we reduced a lot the entropy of bad code! |
|
|
There was a problem hiding this comment.
I saw it. I'm think we can omit it without loosing quality of tutorial.
There was a problem hiding this comment.
OK, but then you have a list with just one item. 😃 Fold it into the previous paragraph, perhaps?
There was a problem hiding this comment.
Ok, will this applicable: Daniil-Osokin@5a490ef?
There was a problem hiding this comment.
@dreamworld Hi! As you see we've concluded to one more improvement. Could you please add the commit above into PR or just make the same changes?
|
@dreamworld Thanks a lot! |
|
👍 |
dnn cleanup: On-fly-quantization removal #2498 On-fly-quantization is first introduced via #20228. We decided to remove it but keep int8 layers implementation because on-fly-quantization is less practical given the fact that there has been so many dedicated tools for model quantization. ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
5 participants
