Repository navigation
fix(grok): discover skills with grok inspect and fail workspace probes loudly - #225
Merged
Merged
Conversation
…anges Grok health checks opened a full ACP session, so background probes could hang on authenticate or boot every configured MCP server. They also never reported login state, and the snapshot locked model changes to a new thread even though session/set_model already works. The check now runs grok --version, grok models, then a single ACP initialize and reads models from _meta.modelState. Failed initialize degrades to warning. grok-build is never sent as a model id. Adapted from pingdotgg#9154 and pingdotgg#8392. Made by Grok 4.6 High in Grok Build via Orca.
Keep the Grok probe PR current with main.
…s loudly Grok snapshots never listed skills, so the composer $ picker had nothing from the CLI catalog. grok inspect --json already reports user, project, bundled, and plugin skills. Machine-level health checks recover a failed inspect to an empty list. snapshotForCwd re-runs inspect in the thread workspace so a failed probe is not cached as empty. Composer cwd refresh still uses the machine snapshot until a client calls snapshotForCwd. Adapted from pingdotgg#8358 and the Grok portions of pingdotgg#9180. Made by Grok 4.6 High in Grok Build via Orca.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
type:provider
Greptile SummaryAdds workspace-scoped Grok skill discovery so project skills can refresh independently of the machine-level provider snapshot. The driver coverage exercises disabled fallback behavior, workspace skill replacement, and error wrapping for failed workspace probes. Confidence Score: 5/5Merge-safe: there are no outstanding blocking issues. The prior test-coverage thread was manually resolved by leoisadev1 without explanation. Reviews (3): Last reviewed commit: "merge main into grok skills stack" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Greptile asked for driver-level coverage of snapshotForCwd. Helper tests already covered inspect parsing; this exercises GrokDriver.create. Disabled instances skip inspect. Enabled instances replace machine skills and wrap inspect failures as ProviderDriverError via Effect.flip. Made by Grok 4.6 High in Grok Build via Orca.
This was referenced Sep 13, 2026
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Grok snapshots never listed skills, so the composer
$picker had nothing from the CLI catalog.grok inspect --jsonalready reports user, project, bundled, and plugin skills.A failed inspect must not be cached as an empty workspace catalog.
Changes
Add
discoverGrokSkillsviagrok inspect --json. Machine-level health checks recover probe failures to an empty list.ProviderInstance.snapshotForCwdre-runs inspect in the thread workspace and fails loudly so an empty catalog is not cached.Composer cwd refresh still uses the machine snapshot until a client calls
snapshotForCwd. Cursor composer and mobile wiring from upstream pingdotgg#9180 are not in this PR.Upstream
Adapted from pingdotgg/t3code#8358 skill discovery and the Grok portions of pingdotgg/t3code#9180. Depends on #214 for the rewritten Grok health check.
Scope
This PR is Grok skills only.
Assigned Grok ports:
Verification
Stacked on #214. Leave both open.
Made by Grok 4.6 High in Grok Build via Orca.