keyring: fix typo in EACCES check#235
Merged
rhatdan merged 1 commit intoopencontainers:mainfrom Oct 8, 2025
Merged
Conversation
Commit 965323e ("SetKeyLabel: add thread group leader requirement") added verification that the caller of SetKeyLabel is the thread-group leader, however the check had a typo in it, which would almost always cause all errors to be treated as ErrNotTGLeader. It's a bit of a shame that os.Getuid() and os.Getpid() are untyped, as a one-character typo like this can really easily cause bugs without type checking... Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
requested review from
kolyshkin,
mrunalp,
rhatdan,
runcom and
thaJeztah
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 965323e ("SetKeyLabel: add thread group leader requirement")
added verification that the caller of SetKeyLabel is the thread-group
leader, however the check had a typo in it, which would almost always
cause all errors to be treated as ErrNotTGLeader.
It's a bit of a shame that os.Getuid() and os.Getpid() are untyped, as a
one-character typo like this can really easily cause bugs without type
checking...
Signed-off-by: Aleksa Sarai [email protected]