Skip to content

ci: update Go 1.21 support#202

Merged
rhatdan merged 4 commits intoopencontainers:mainfrom
michalbiesek:feat-go-1.21
Aug 14, 2023
Merged

ci: update Go 1.21 support#202
rhatdan merged 4 commits intoopencontainers:mainfrom
michalbiesek:feat-go-1.21

Conversation

@michalbiesek
Copy link
Copy Markdown
Contributor

@michalbiesek michalbiesek commented Aug 14, 2023

No description provided.

thaJeztah
thaJeztah reviewed Aug 14, 2023
View reviewed changes
.github/workflows/validate.yml Outdated
go-version: 1.21.x
- uses: golangci/golangci-lint-action@v3
with:
version: v1.51
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to update golangci-lint as well, as go1.21 support was added in v1.54; https://github.com/golangci/golangci-lint/releases/tag/v1.54.0

Copy link
Copy Markdown
Contributor Author

@michalbiesek michalbiesek Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Aug 14, 2023

Looks like the updated linter doesn't like the unused (but named) arguments in the stubs.

I guess we can either update the linter settings (in golangci-lint.yml) or remove the names

Not sure what's best here; having the names could still be useful to understand the arguments that are passed to the stubs, but perhaps that's not a big issue;

  Warning: unused-parameter: parameter 'options' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'options' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'path' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'fileLabel' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'path' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'label' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'label' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'label' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'fpath' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'class' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'fpath' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'fpath' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'fpath' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'fpath' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'label' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'pid' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'val' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'source' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'sourceRange' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'fd' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'label' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'label' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'label' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'mode' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'label' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'val' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'src' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'fpath' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'src' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'user' seems to be unused, consider removing or renaming it as _ (revive)

@rhatdan
Copy link
Copy Markdown
Collaborator

rhatdan commented Aug 14, 2023

LGTM
Thanks @michalbiesek
Could you make the suggested changes to the stub functions.

@michalbiesek
Copy link
Copy Markdown
Contributor Author

michalbiesek commented Aug 14, 2023

@rhatdan
Done. I have removed the unused parameters.

thaJeztah
thaJeztah approved these changes Aug 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is happy 😄

thanks!

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Aug 14, 2023

@rhatdan could you re-LGTM this one?

@thaJeztah thaJeztah mentioned this pull request Aug 14, 2023
Merged
@rhatdan
Copy link
Copy Markdown
Collaborator

rhatdan commented Aug 14, 2023

LGTM

@rhatdan rhatdan merged commit b809725 into opencontainers:main Aug 14, 2023
@michalbiesek michalbiesek deleted the feat-go-1.21 branch August 14, 2023 17:30
@michalbiesek
Copy link
Copy Markdown
Contributor Author

michalbiesek commented Aug 14, 2023

@thaJeztah @rhatdan just FYI: The new CI jobs for Go 1.21.x are not marked as required.
Screenshot from 2023-08-14 19-35-46

project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-runner-as-gitea-act-runner-fork that referenced this pull request Aug 3, 2025
@viceice-bot
Update module github.com/opencontainers/selinux to v1.12.0 (#801)
6bff61d 
This PR contains the following updates:

| Package | Change | Age | Confidence |
|---|---|---|---|
| [github.com/opencontainers/selinux](https://github.com/opencontainers/selinux) | `v1.11.0` -> `v1.12.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fopencontainers%2fselinux/v1.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fopencontainers%2fselinux/v1.11.0/v1.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>opencontainers/selinux (github.com/opencontainers/selinux)</summary>

### [`v1.12.0`](https://github.com/opencontainers/selinux/releases/tag/v1.12.0)

[Compare Source](opencontainers/selinux@v1.11.1...v1.12.0)

This release removes deprecated functions from the `label` package,
and improves documentation and error reporting of `SetCreateKey`.

#### What's Changed

- VERSION: remove by [@&#8203;kolyshkin](https://github.com/kolyshkin) in opencontainers/selinux#217
- CI: add AlmaLinux 8, CentOS Stream 9, and Fedora by [@&#8203;AkihiroSuda](https://github.com/AkihiroSuda) in opencontainers/selinux#221
- ci: install git-core by [@&#8203;kolyshkin](https://github.com/kolyshkin) in opencontainers/selinux#224
- CI: add openSUSE Tumbleweed by [@&#8203;AkihiroSuda](https://github.com/AkihiroSuda) in opencontainers/selinux#223
- Bump Go version, deps, fix some linter issues... by [@&#8203;kolyshkin](https://github.com/kolyshkin) in opencontainers/selinux#218
- label: remove deprecated stuff by [@&#8203;kolyshkin](https://github.com/kolyshkin) in opencontainers/selinux#228
- Improve SetKeyCreate error reporting, fix test flakes by [@&#8203;kolyshkin](https://github.com/kolyshkin) in opencontainers/selinux#227

**Full Changelog**: opencontainers/selinux@v1.11.1...v1.12.0

### [`v1.11.1`](https://github.com/opencontainers/selinux/releases/tag/v1.11.1)

[Compare Source](opencontainers/selinux@v1.11.0...v1.11.1)

#### What's Changed

- Bump to v1.11.0 by [@&#8203;rhatdan](https://github.com/rhatdan) in opencontainers/selinux#197
- fix some error by [@&#8203;ningmingxiao](https://github.com/ningmingxiao) in opencontainers/selinux#200
- ci: update Go 1.21 support by [@&#8203;michalbiesek](https://github.com/michalbiesek) in opencontainers/selinux#202
- Extend `build-cross` target with `riscv64` arch by [@&#8203;michalbiesek](https://github.com/michalbiesek) in opencontainers/selinux#201
- Remove nolint annotations for unix errno comparisons by [@&#8203;kolyshkin](https://github.com/kolyshkin) in opencontainers/selinux#203
- ci: bump some actions by [@&#8203;kolyshkin](https://github.com/kolyshkin) in opencontainers/selinux#205
- Misc nitpicks by [@&#8203;kolyshkin](https://github.com/kolyshkin) in opencontainers/selinux#206
- pwalk, pwalkdir: fix walk vs remove race by [@&#8203;kolyshkin](https://github.com/kolyshkin) in opencontainers/selinux#204
- Update GitHub Actions CI Go matrix for Go v1.22 by [@&#8203;austinvazquez](https://github.com/austinvazquez) in opencontainers/selinux#209
- Update GitHub Actions packages to resolve deprecation warnings. by [@&#8203;austinvazquez](https://github.com/austinvazquez) in opencontainers/selinux#208
- Add dependabot config by [@&#8203;kolyshkin](https://github.com/kolyshkin) in opencontainers/selinux#210
- build(deps): bump tim-actions/get-pr-commits from 1.3.0 to 1.3.1 by [@&#8203;dependabot](https://github.com/dependabot) in opencontainers/selinux#211
- build(deps): bump golangci/golangci-lint-action from 4 to 6 by [@&#8203;dependabot](https://github.com/dependabot) in opencontainers/selinux#213
- Show SELinux label on failure by [@&#8203;rhatdan](https://github.com/rhatdan) in opencontainers/selinux#216

#### New Contributors

- [@&#8203;ningmingxiao](https://github.com/ningmingxiao) made their first contribution in opencontainers/selinux#200
- [@&#8203;michalbiesek](https://github.com/michalbiesek) made their first contribution in opencontainers/selinux#202
- [@&#8203;dependabot](https://github.com/dependabot) made their first contribution in opencontainers/selinux#211

**Full Changelog**: opencontainers/selinux@v1.11.0...v1.11.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS40My41IiwidXBkYXRlZEluVmVyIjoiNDEuNDMuNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/801
Reviewed-by: earl-warren <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
Co-committed-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@kolyshkin kolyshkin Awaiting requested review from kolyshkin kolyshkin is a code owner

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michalbiesek @thaJeztah @rhatdan