gha: also test and lint stubs#189
Merged
rhatdan merged 4 commits intoopencontainers:mainfrom Oct 13, 2022
Merged
Conversation
thaJeztah
requested review from
kolyshkin,
mrunalp,
rhatdan and
runcom
as code owners
Collaborator
While we were cross-compiling the code, we did not run the tests for the stubs. This patch adds a check, running on macOS to verify that the stubs work as intended. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
I need to rebase this one and fix a go-selinux/selinux_stub.go:12: File is not `gofumpt`-ed (gofumpt) |
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
👍 fixed; should be good now 👍 |
rhatdan
reviewed
Oct 13, 2022
go-selinux/selinux_linux.go
Outdated
| return nil | ||
| } | ||
| } | ||
| e := lSetFileLabel(p, label) |
Collaborator
There was a problem hiding this comment.
Nit can you change this to err for consistency.
Member
Author
There was a problem hiding this comment.
Ah, yes, I should do; thought I changed this one, but perhaps it got in another branch
It's unused on other platforms:
go-selinux/rchcon.go:11:6: func `rchcon` is unused (unused)
func rchcon(fpath, label string) error {
^
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While we were cross-compiling the code, we did not run the tests for the stubs. This patch adds a check, running on macOS to verify that the stubs work as intended.