Merged
Conversation
Collaborator
|
LGTM |
Collaborator
|
@lsm5 PTAL |
Member
Author
|
We probably need #183 first (this one includes those changes, but I can rebase it after that). |
Using a vendor directory is common for repositories that produce binaries, but usually not for library-only repositories. Having a vendor directory can be useful to review changes in dependencies, but as this repository only has a single dependency (which is well-known and (usually) requires minimal review), it's probably ok to drop the vendor directory. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
requested review from
kolyshkin,
mrunalp,
rhatdan and
runcom
as code owners
Member
Author
|
rebased; this should be ready for review now, PTAL 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a vendor directory is common for repositories that produce binaries,
but usually not for library-only repositories. Having a vendor directory
can be useful to review changes in dependencies, but as this repository
only has a single dependency (which is well-known and (usually) requires
minimal review), it's probably ok to drop the vendor directory.