Skip to content

Add CODEOWNERS#168

Merged
rhatdan merged 1 commit intoopencontainers:mainfrom
bloodorangeio:codeowners
Nov 12, 2021
Merged

Add CODEOWNERS#168
rhatdan merged 1 commit intoopencontainers:mainfrom
bloodorangeio:codeowners

Conversation

@jdolitsky
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Josh Dolitsky <[email protected]>
Copy link
Copy Markdown
Collaborator

@rhatdan rhatdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Copy Markdown
Collaborator

rhatdan commented Nov 11, 2021

@kolyshkin @thaJeztah @mrunalp PTAL

Copy link
Copy Markdown
Collaborator

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member

Not a blocker, but I'm still a bit on the fence on the added value of the CODEOWNERS file, as that file mostly adds value for more "mono-repos", where specific parts of the code have "owners". In this repository, that's not the case, so it rather duplicates the MAINTAINERS file (but will have to be kept in sync); also see opencontainers/go-digest#70 (comment)

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan rhatdan merged commit 0cb05ae into opencontainers:main Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants