generate: Add --output=PATH and write to stdout by default #129
Conversation
wking
force-pushed
the
generate-output-file
branch
from
f8e1a3d to
50c2ce8
Compare
wking
force-pushed
the
generate-output-file
branch
from
50c2ce8 to
06d61a3
Compare
This makes it easier to post-process output before writing it to disk. For example, you may want to make adjustments with jq and/or write part of the configuration to a different file for consumption by non-OCI tools [1]. [1]: opencontainers#128 (comment) Signed-off-by: W. Trevor King <[email protected]>
|
LGTM |
|
+1 |
|
I think having the default output be a file should remain the same. Maybe there should be an option to output to stdout, and an option to to rename the file output? It could be the same flag too, either a path or "STDOUT" possibly. |
|
On Wed, Jul 06, 2016 at 08:48:31AM -0700, Grant Seltzer Richman wrote:
I like having ‘--output PATH’ always mean “please write to the file at On the other hand, with the default-to-stdout approach, folks don't |
|
+1 I like the idea of defaulting to STDOUT and providing the --output flag for the file. |
|
LGTM |
The switch to --output in 06d61a3 (generate: Add --output=PATH and write to stdout by default, 2016-07-05, opencontainers#129) was too narrow. There's no need to change directories now that the output path is configurable. Signed-off-by: W. Trevor King <[email protected]>
6 participants
This makes it easier to post-process output before writing it to disk. For example, you may want to make adjustments with jq and/or write part of the configuration to a different file for consumption by non-OCI tools.