Skip to content

Windows - correct mounts#821

Merged
hqhq merged 1 commit intoopencontainers:masterfrom
lowenna:clarifymountntfs
May 16, 2017
Merged

Windows - correct mounts#821
hqhq merged 1 commit intoopencontainers:masterfrom
lowenna:clarifymountntfs

Conversation

@lowenna
Copy link
Contributor

@lowenna lowenna commented May 13, 2017

Signed-off-by: John Howard [email protected]

Not sure where the mis-information came from, but the mounts section on Windows has incorrect information.

  • The type is not used
  • The example was incorrect as the source is not a volume path
  • Better not have generic example rather than including a users name ;)
  • Clarification of what the source can be (although we hope to be more reaching in future releases here)

config.md Outdated
"type": "ntfs",
"source": "\\\\?\\Volume\\{2eca078d-5cbc-43d3-aff8-7e8511f60d0e}\\",
"destination": "C:\\folder-inside-container",
"source": "C:\\folder-on-host}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the unbalanced closing brace intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a typo. Updated.

Signed-off-by: John Howard <[email protected]>
@lowenna lowenna force-pushed the clarifymountntfs branch from 53cfbc6 to 861eb5b Compare May 15, 2017 17:28
@lowenna lowenna mentioned this pull request May 15, 2017
@tianon
Copy link
Member

tianon commented May 15, 2017

LGTM

Approved with PullApprove

1 similar comment
@hqhq
Copy link
Contributor

hqhq commented May 16, 2017

LGTM

Approved with PullApprove

@hqhq hqhq merged commit faec82c into opencontainers:master May 16, 2017
@vbatts vbatts mentioned this pull request Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants