config.md: specify config usage#803
Conversation
config.md
Outdated
| # <a name="containerConfigurationFile" />Container Configuration file | ||
|
|
||
| This configuration file contains metadata necessary to implement standard operations against the container. | ||
| This configuration file contains metadata necessary to implement standard operations against the creation of a container. |
There was a problem hiding this comment.
process.args is used by start and some hooks are used by delete. But kill doesn't need anything from then config. So we can draw a distinction here, but your current wording isn't quite it.
I'd rather link "standard operations" to the runtime.md section and maybe weaken it to "some standard operations". But I'd avoid calling out creation without also mentioning the other impacted operations.
|
I think I tend to agree with @wking here -- in my mind, the Regardless, I think this is something we could discuss further clarifying post-1.0? |
Mashimiao
force-pushed
the
config-specify-config
branch
from
92b2110 to
b2ec523
Compare
Mashimiao
changed the title
|
LGTM |
|
Without the config.json there is no container and no operations to run against a container so I am in favor of closing this PR. |
config.md
Outdated
| # <a name="containerConfigurationFile" />Container Configuration file | ||
|
|
||
| This configuration file contains metadata necessary to implement standard operations against the container. | ||
| This configuration file contains metadata necessary to implement some [standard operations](runtime.md#operations) against the container. |
There was a problem hiding this comment.
Lets remove the "some" part but keep the link
config.json is used some operations of container, we should specify this. Signed-off-by: Ma Shimiao <[email protected]>
Mashimiao
force-pushed
the
config-specify-config
branch
from
b2ec523 to
773ebb2
Compare
|
OK, updated. |
|
LGTM |
1 similar comment
|
LGTM |
5 participants
config.json is used for creation of container not for
operations of container, we should specify this.
Signed-off-by: Ma Shimiao [email protected]