schema: Add enumeration to rootfsPropagation values#775
schema: Add enumeration to rootfsPropagation values#775mrunalp merged 1 commit intoopencontainers:masterfrom
Conversation
Signed-off-by: zhouhao <[email protected]>
|
@wking I think it should be in the |
|
On Thu, Apr 20, 2017 at 10:34:58PM -0700, Zhou Hao wrote:
@wking I think it should be in the `config.go` file to increase the
corresponding value, but I do not know how to name it, is it should
be made such a style:
`const (`
` ArchX86 Arch = "SCMP_ARCH_X86"`
I'm not sure what you mean. I'd expect the current [1]:
Its value is either slave, private, or shared.
should be adjusted to:
Runtimes MUST support `slave`, `private`, [whatever other entries
are in the enum].
[1]: https://github.com/opencontainers/runtime-spec/blob/cfc95a56767ecc7249bb43ac29bf8e9ee06ad415/config-linux.md#rootfs-mount-propagation
|
|
I'm +1 on this (as discussed on our maintainer call just now) -- for values like "CPU Quota", the value in our spec is the value as defined in the kernel, so it makes a lot of sense to punt on "valid values" to the kernel docs/implementation. For values like |
Signed-off-by: zhouhao [email protected]