meeting: Include README link in DESCRIPTION body#758
Merged
vbatts merged 1 commit intoopencontainers:masterfrom Apr 10, 2017
Merged
meeting: Include README link in DESCRIPTION body#758vbatts merged 1 commit intoopencontainers:masterfrom
vbatts merged 1 commit intoopencontainers:masterfrom
Conversation
wking
force-pushed
the
ics-description-link-readme
branch
from
b4bed00 to
9a497c2
Compare
And bump DTSTAMP for the touched VEVENTS. com.android.calendar version 7.1.1 only displays the DESCRIPTION body, and does not provide a link to ALTREP (in fact, I don't see any instances of ALTREP in the source [1]). Including the README link in the DESCRIPTION body gives folks using that calendar application an easy way to get to the README section. The ICS was validated with [2]. [1]: https://android.googlesource.com/platform/packages/apps/Calendar/+/android-7.1.1_r38 [2]: https://icalendar.org/validator.html Signed-off-by: W. Trevor King <[email protected]>
Contributor
Author
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And bump
DTSTAMPfor the touchedVEVENTS.com.android.calendar version 7.1.1 only displays the
DESCRIPTIONbody, and does not provide a link toALTREP(in fact, I don't see any instances ofALTREPin the source). Including the README link in theDESCRIPTIONbody gives folks using that calendar application an easy way to get to the README section.The ICS was validated here.
This will conflict with #757. There's already one LGTM there, so I suggest landing that one first. However, I'm happy to rebase whichever PR lands second.