Merged
Conversation
Signed-off-by: zhouhao <[email protected]>
Contributor
Member
|
I don't see that it makes the help info incorrect. I'm two-ways about the default make target being |
Contributor
|
@vbatts Not that incorrect, just not completely accurate. To me it means "make needs an target, which can be fmt or validate", if we make validate default and target optional, I would like to see something like: I'm also fine with changing the default target to be running the tests, just needs to fix help information as well. |
Member
|
@hqhq oh oh, good catch. so yes, using square brackets there would be more accurate 😸 |
Signed-off-by: zhouhao <[email protected]>
Author
|
@hqhq Thanks for your advice, updated, PTAL. |
Contributor
Author
Member
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhouhao [email protected]