config-linux: make interface name clear#713
Conversation
Signed-off-by: Ma Shimiao <[email protected]>
|
Are you sure this is correct? There are an awful lot of |
|
cgroups works on host, you can't run a container with limiting an interface which not exists on host., cgroups will not accept that. For example by runc: $ sudo runc run --bundle ~/testdir test |
|
While I'm sure this is a correct statement, this is IMO another instance where we shouldn't be adding wording around Linux kernel implementation details. If someone wants to put a random value in a field they'd better understand what they're actually doing (in terms of the kernel features they're using) otherwise things would break no matter how much guidance we give. From my PoV I see no reason why this restriction will always be true in the kernel -- how is the case handled where you have a file descriptor set up in a different network namespace (for instance)? if the kernel changes some behaviour (or they extend it) then we'd have to update the spec. |
|
I think if we don't make it clear, people may be confused interface name should be which in container network namespace or in runtime network namespace. |
|
I think it mis-read it the first time sorry. It does seem correct. I'm indifferent about adding this line, I think its fine leaving it out like @cyphar said but its also fine adding it as the additional is pretty straight forward. |
|
ping @opencontainers/runtime-spec-maintainers |
| * **`priorities`** *(array, OPTIONAL)* - specifies a list of objects of the priorities assigned to traffic originating from processes in the group and egressing the system on various interfaces. | ||
| The following parameters can be specified per-priority: | ||
| * **`name`** *(string, REQUIRED)* - interface name | ||
| * **`name`** *(string, REQUIRED)* - interface name in [runtime network namespace](glossary.md#runtime-namespace) |
There was a problem hiding this comment.
It appears the rest of this file is using footer links ([link text][link ID] with then a [link ID]: URL at the bottom of the file such as [container-namespace2]: glossary.md#container_namespace); should we stay consistent on that?
There was a problem hiding this comment.
It appears the rest of this file is using footer links…
I think those just slipped through #687 and have filed #799 to catch them up. @Mashimiao's current inline links match the current style for internal references.
Signed-off-by: Ma Shimiao [email protected]