Conversation
wking
left a comment
wking
left a comment
There was a problem hiding this comment.
The other changes (requiring type/soft/hard and not requiring mounts) look good to me.
schema/config-schema.json
Outdated
| "type": "object", | ||
| "required": [ | ||
| "uid", | ||
| "gid" |
There was a problem hiding this comment.
We can't add this to the JSON Schema, because they're only required on Linux. Windows entries will not have them.
There was a problem hiding this comment.
That being the case, should the user field should be removed from the config-schema, into different types（config-linux.json/config-windows.json etc）.
There was a problem hiding this comment.
should the user field should be removed from the
config-schema, into different types (config-linux.json/config-windows.jsonetc).
You could do that if you like, but I don't think it's worth the trouble. I'd rather leave the user fields optional in the JSON Schema and check for any platform-specific requirements in runtime-tools' Go validation.
Signed-off-by: zhouhao <[email protected]>
Signed-off-by: zhouhao <[email protected]>
|
LGTM |
1 similar comment
|
LGTM |
4 participants
Signed-off-by: zhouhao [email protected]