Remove uid/gid mapping limit depend on kernel#693
Merged
crosbymichael merged 1 commit intoopencontainers:masterfrom Feb 22, 2017
Merged
Remove uid/gid mapping limit depend on kernel#693crosbymichael merged 1 commit intoopencontainers:masterfrom
crosbymichael merged 1 commit intoopencontainers:masterfrom
Conversation
mrunalp
reviewed
Feb 22, 2017
config-linux.md
Outdated
|
|
||
| The runtime SHOULD NOT modify the ownership of referenced filesystems to realize the mapping. | ||
| There is a limit of 5 mappings which is the Linux kernel hard limit. | ||
| Note that there might be a limit of mapping entries by the [kernel][user-namespaces]. |
Contributor
There was a problem hiding this comment.
nit: ... in the Linux kernel.
Member
|
LGTM |
mikebrow
reviewed
Feb 22, 2017
config-linux.md
Outdated
|
|
||
| The runtime SHOULD NOT modify the ownership of referenced filesystems to realize the mapping. | ||
| There is a limit of 5 mappings which is the Linux kernel hard limit. | ||
| Note that there might be a limit of mapping entries by the [kernel][user-namespaces]. |
Member
There was a problem hiding this comment.
nit: The number of mapping entries MAY be limited by the [kernel][user-namespaces].
Signed-off-by: Qiang Huang <[email protected]>
hqhq
force-pushed
the
dont_limit_mapping
branch
from
d8818db to
a5c4e91
Compare
Contributor
Author
|
Updated. |
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Qiang Huang [email protected]