travis: add go1.6 and work around golint#352
Conversation
| before_install: | ||
| - go get golang.org/x/tools/cmd/vet | ||
| - go get github.com/golang/lint/golint | ||
| - go version | grep -qE '(go1.5|go1.6)' && go get github.com/golang/lint/golint |
There was a problem hiding this comment.
grep -q 'go1.[56]' should be sufficient.
There was a problem hiding this comment.
yeah, but now i'm trying to figure out the proper subterminal return codes,
because this is now failing as grep is not finding the version
On Sat, Mar 19, 2016 at 11:50 AM, W. Trevor King [email protected]
wrote:
In .travis.yml
#352 (comment):@@ -8,13 +9,13 @@ sudo: false
before_install:
- go get golang.org/x/tools/cmd/vet
- go get github.com/golang/lint/golint
- go version | grep -qE '(go1.5|go1.6)' && go get github.com/golang/lint/golint
grep -q 'go1.[56]' should be sufficient.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/opencontainers/specs/pull/352/files/60c7a94edb5c008ef08bbfecaf22f4758d5a242d#r56750650
There was a problem hiding this comment.
@vbatts what about doing something like what I did for containerd to check for a minimum version?: docker-archive/containerd@c6680da
vbatts
force-pushed
the
go-version-golint
branch
from
60c7a94 to
cb02ebd
Compare
|
my goodness. Travis is having API threshold issues, but this finally passes.
PTAL |
|
cb02ebd looks good to me.
|
|
On Mon, Mar 21, 2016 at 10:42:32AM -0700, Marcos Nils wrote:
This approach looks fine to me to, although bumping @vbatts' approach |
|
@marcosnils I looked, but it's not like the specs code doesn't support prior golang versions, but that we can't use the |
|
@vbatts exactly. By following the approach I'm proposing you wouldn't have to change the regex each time a new golang version is added to the travis file. You just specify the minimum version which It might be a good idea also to add the |
closes opencontainers#350 Signed-off-by: Vincent Batts <[email protected]>
vbatts
force-pushed
the
go-version-golint
branch
from
cb02ebd to
54cd96d
Compare
|
k. I've updated it, but the travis I can consolidate one or the other, for it be be cleaner and all done in the |
|
@vbatts +1 to consolidate. |
|
@vbatts Is the build expected to pass here? |
|
@mrunalp all green |
|
LGTM |
1 similar comment
|
LGTM |
5 participants
closes #350
Signed-off-by: Vincent Batts [email protected]