Skip to content

Appropriately mark optional fields as omitempty#283

Merged
vbatts merged 2 commits intoopencontainers:masterfrom
jonboulle:master
Jan 4, 2016
Merged

Appropriately mark optional fields as omitempty#283
vbatts merged 2 commits intoopencontainers:masterfrom
jonboulle:master

Conversation

@jonboulle
Copy link
Copy Markdown
Contributor

@jonboulle jonboulle commented Dec 24, 2015

Signed-off-by: Jonathan Boulle [email protected]

per #282 (comment)

@jonboulle jonboulle mentioned this pull request Dec 24, 2015
Closed
@hqhq
Copy link
Copy Markdown
Contributor

hqhq commented Dec 25, 2015

LGTM

@arcnmx
Copy link
Copy Markdown
Contributor

arcnmx commented Dec 29, 2015

Oh, one other item I forgot about that should be omitempty is runtime/linux's rootfsPropagation.

@hqhq
Copy link
Copy Markdown
Contributor

hqhq commented Dec 30, 2015

@arcnmx Thanks, @jonboulle Can you update for that? Thanks.

@jonboulle
Copy link
Copy Markdown
Contributor Author

jonboulle commented Dec 31, 2015

done

On Wed, Dec 30, 2015 at 2:16 AM, Qiang Huang [email protected]
wrote:

@arcnmx https://github.com/arcnmx Thanks, @jonboulle
https://github.com/jonboulle Can you update for that? Thanks.

—
Reply to this email directly or view it on GitHub
#283 (comment).

@hqhq
Copy link
Copy Markdown
Contributor

hqhq commented Dec 31, 2015

@jonboulle You need to sign your commit.

@jonboulle
Copy link
Copy Markdown
Contributor Author

jonboulle commented Dec 31, 2015

Sigh. Done.

On Thu, Dec 31, 2015 at 12:15 PM, Qiang Huang [email protected]
wrote:

@jonboulle https://github.com/jonboulle You need to sign your commit.

—
Reply to this email directly or view it on GitHub
#283 (comment).

@hqhq
Copy link
Copy Markdown
Contributor

hqhq commented Jan 2, 2016

Thanks, still LGTM.

@vbatts
Copy link
Copy Markdown
Member

vbatts commented Jan 4, 2016

LGTM

vbatts added a commit that referenced this pull request Jan 4, 2016
@vbatts
Merge pull request #283 from jonboulle/master
3c294d5 
Appropriately mark optional fields as omitempty
@vbatts vbatts merged commit 3c294d5 into opencontainers:master Jan 4, 2016
@wking wking mentioned this pull request Jan 20, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonboulle @hqhq @arcnmx @vbatts