ci: use supported Go versions#1300
Merged
cyphar merged 1 commit intoopencontainers:mainfrom Oct 22, 2025
Merged
Conversation
The upside is, we don't have to bump the versions here every 6 months. The downside is, CI might break once the new Go is out. Overall I think it is net positive. Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
requested review from
AkihiroSuda,
crosbymichael,
cyphar,
dqminh,
giuseppe,
hqhq,
mrunalp,
thaJeztah,
tianon and
utam0k
as code owners
Contributor
Author
|
This is a trivial yet important PR; guess it can be included into v1.3. |
Closed
Is there any downside to adding one? |
AkihiroSuda
approved these changes
Oct 21, 2025
Member
|
tianon
approved these changes
Oct 22, 2025
Member
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
One question (getting at the intent of the go.mod inclusion elsewhere), but otherwise LGTM
| strategy: | ||
| matrix: | ||
| go: [1.21.x, 1.22.x] | ||
| go: [oldstable, stable] |
Member
There was a problem hiding this comment.
Maybe instead of go.mod we just put in a lower bound of what we want to reasonably support with our Go code/structs? Is that 1.21.x?
cyphar
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upside is, we don't have to bump the versions here every 6 months.
The downside is, CI might break once the new Go is out.
Overall I think it is net positive.
PS I can't do something like @tianon did in opencontainers/image-spec#1229 as this repo lacks go.mod file 🤷🏻