Conversation
kershawmehta
requested review from
AkihiroSuda,
crosbymichael,
cyphar,
dqminh,
giuseppe,
hqhq,
kolyshkin,
mrunalp,
thaJeztah,
tianon and
utam0k
as code owners
|
Only glancing over; would it be clearer to move the removal of devices to a separate commit? Currently it made me almost consider that "namespaces" was a replacement for devices which was a bit confusing. |
|
Or is it a replacement? 🙈 |
| @@ -0,0 +1,138 @@ | |||
| { | |||
| "ociVersion": "0.5.0-dev", | |||
There was a problem hiding this comment.
The ociVersion is the same as used in spec-example.json.
The deletion of devices and the addition of namespaces are unrelated. However, I thought that having these in a single PR would be more efficient, given this is the resultant of what is supported by z/OS Container Platform. |
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
Please amend the first commit to provide a better commit message than "zos updates". You can start by taking the description of this PR and copy-paste it.
This PR proposes updates to the OCI runtime spec with z/OS platform-specific details, including adding namespaces, adding noNewPrivileges flag, and removing devices. These changes are currently in use by the IBM z/OS Container Platform (zOSCP) product - details can be found here: https://www.ibm.com/products/zos-container-platform. Signed-off-by: Neil Johnson <[email protected]> Signed-off-by: Kershaw Mehta <[email protected]>
Done. |
4 participants
This PR proposes updates to the OCI runtime spec with z/OS platform-specific details, including adding namespaces, adding noNewPrivileges flag, and removing devices. These changes are currently in use by the IBM z/OS Container Platform (zOSCP) product - details can be found here: https://www.ibm.com/products/zos-container-platform.
Note: The "removing of devices" is not considered to be an incompatible change since no user would have been using the z/OS-specific portion of the runtime spec, prior to the initial zOSCP release.