ci: Add a github actions workflow for lint#1257
Merged
tianon merged 1 commit intoopencontainers:mainfrom Dec 11, 2024
Merged
Conversation
utam0k
requested review from
AkihiroSuda,
crosbymichael,
cyphar,
dqminh,
giuseppe,
hqhq,
kolyshkin,
mrunalp,
thaJeztah and
tianon
as code owners
AkihiroSuda
reviewed
Jun 16, 2024
utam0k
force-pushed
the
ci-lint
branch
2 times, most recently
from
9a08129 to
be9bc85
Compare
AkihiroSuda
approved these changes
Jun 16, 2024
kolyshkin
reviewed
Jun 16, 2024
Jpjames1
approved these changes
Oct 30, 2024
Member
Author
|
@kolyshkin PTAL 🙏 |
kolyshkin
reviewed
Oct 30, 2024
kolyshkin
reviewed
Oct 30, 2024
Contributor
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
one nit; lgtm otherwise
Member
Author
|
@kolyshkin PTAL 🙏 |
Member
|
Looks like linting is working, and detected an issue; could you add a commit (as first commit) to correct that issue? diff --git a/schema/config-schema.json b/schema/config-schema.json
index cb74342..5124def 100644
--- a/schema/config-schema.json
+++ b/schema/config-schema.json
@@ -226,14 +226,14 @@
"properties": {
"initial": {
"type": "string",
- "pattern": "^[0-9, -]*$"
+ "pattern": "^[0-9, -]*$"
},
"final": {
"type": "string",
- "pattern": "^[0-9, -]*$"
+ "pattern": "^[0-9, -]*$"
}
}
- }
+ }
}
},
"linux": { |
Signed-off-by: utam0k <[email protected]>
tianon
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to prevent like #1255
It works fine: https://github.com/utam0k/runtime-spec/actions/runs/9534058439/job/26278029545