config: add annotation for exec isolated CPU affinity#1252
Closed
bartwensley wants to merge 1 commit intoopencontainers:mainfrom
Closed
config: add annotation for exec isolated CPU affinity#1252bartwensley wants to merge 1 commit intoopencontainers:mainfrom
bartwensley wants to merge 1 commit intoopencontainers:mainfrom
Conversation
The runc container runtime recently introduced functionality to direct exec operations to the first isolated CPU in a container cgroup cpuset. This is enabled through a new runc specific container annotation: org.opencontainers.runc.exec.isolated-cpu-affinity-transition See opencontainers/runc@afc23e3397 for the details. This new functionality is also required in the crun container runtime and will be added soon. This purpose of this commit is to add a new annotation to the OCI runtime specification that would be used by any runtime that implements this new functionality: org.opencontainers.runtime.exec.isolated-cpu-affinity-transition The runc implementation should switch to using the new annotation once it is accepted. Signed-off-by: Bart Wensley <[email protected]>
bartwensley
requested review from
AkihiroSuda,
crosbymichael,
cyphar,
dqminh,
giuseppe,
hqhq,
kolyshkin,
mrunalp,
thaJeztah,
tianon and
utam0k
as code owners
AkihiroSuda
requested changes
May 17, 2024
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
This should be a proper JSON field
Member
|
Agree -- a runtime-specific annotation seems like a really great way for one runtime to experiment with adding functionality like this before it's fully standardized or proven out, but as soon as it's something desirable for interoperability, it seems worth making a proper "feature" instead. |
This was referenced May 18, 2024
Author
|
I am abandoning this in favor of #1253 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runc container runtime recently introduced functionality to direct exec operations to the first isolated CPU in a container cgroup cpuset. This is enabled through a new runc specific container annotation: org.opencontainers.runc.exec.isolated-cpu-affinity-transition
See opencontainers/runc@afc23e3397 for the details.
This new functionality is also required in the crun container runtime and will be added soon. This purpose of this commit is to add a new annotation to the OCI runtime specification that would be used by any runtime that implements this new functionality:
org.opencontainers.runtime.exec.isolated-cpu-affinity-transition
The runc implementation should switch to using the new annotation once it is accepted.