ping @opencontainers/runtime-spec-maintainers

Sorry, late to the party; I see various features being added; if we follow SemVer, should this increment the minor version, not the patch version? So v1.2.0 ?

@thaJeztah Thanks for your comment. We haven't met the milestone for v1.2.0 yet.
https://github.com/opencontainers/runtime-spec/milestone/18

We haven't met the milestone for v1.2.0 yet.
https://github.com/opencontainers/runtime-spec/milestone/18

Hm, right, but we passed changes for a patch release, as there's features in the diff.

SemVer is very clear on this; the version is baseed on the changes you're shipping, so you don't know the version "ahead of time". Is there a specific reason that milestone MUST be v1.2.0? Otherwise that milestone can become for v1.3.0.

I think there's 3 options;

1. if there's critical fixes merged that must be released; create a branch from the v1.1.0 tag, cherry-pick the fixes, and tag as v1.1.1
2. do a regular release; follow SemVer, which means: determine the version based on the changes; tag as v1.2.0, and move the linked milestone to "v1.3.0"
3. if there's a specific reason the next release MUST be v1.2.0; do a pre-release for ("v1.2.0-beta.1")

do a regular release; follow SemVer, which means: determine the version based on the changes; tag as v1.2.0, and move the linked milestone to "v1.3.0"

👍

@utam0k WDYT about renaming this to v1.2.0 ?

I understand. I think it's good. I'll update it within a few days.

@opencontainers/runtime-spec-maintainers I renamed this PR to v1.2.0. If you disagree, please cancel your vote. If you haven't done so already, please vote 🙏

@cyphar ptal.

🚀 It's time to release v1.2.0