config: improve bind mount and propagation doc#1228
Merged
tianon merged 1 commit intoopencontainers:mainfrom Sep 22, 2023
Merged
config: improve bind mount and propagation doc#1228tianon merged 1 commit intoopencontainers:mainfrom
tianon merged 1 commit intoopencontainers:mainfrom
Conversation
Current documentation talks about bind/rbind and various propagation flags (shared, slave, private, unbindable etc.) as being filesystem- specific options, and refers to mount(8) section describing filesystem-specific options. That is wrong, because bind mounts are a separate class of mounts, not related to file systems. Fix the confusion, and link to sharedsubtree.txt kernel document as it happens to be the best source of information about the topic (not counting the kernel sources). Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
requested review from
AkihiroSuda,
crosbymichael,
cyphar,
dqminh,
giuseppe,
hqhq,
mrunalp,
thaJeztah,
tianon,
utam0k and
vbatts
as code owners
AkihiroSuda
approved these changes
Sep 22, 2023
tianon
approved these changes
Sep 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current documentation talks about bind/rbind and various propagation flags (shared, slave, private, unbindable etc.) as being filesystem-specific options, and refers to mount(8) section describing filesystem-specific options.
That is wrong, because bind mounts are a separate class of mounts, not related to file systems.
Fix the confusion, and link to sharedsubtree.txt kernel document as it happens to be the best source of information about the topic (not counting the kernel sources).