config: clarify Linux mount options#1181
Merged
tianon merged 1 commit intoopencontainers:mainfrom Feb 10, 2023
Merged
Conversation
AkihiroSuda
requested review from
crosbymichael,
cyphar,
dqminh,
giuseppe,
hqhq,
kolyshkin,
mrunalp,
thaJeztah,
tianon and
vbatts
as code owners
AkihiroSuda
force-pushed
the
clarify-mount-options
branch
from
55c5f5e to
b35b6e2
Compare
The former wording was inconsistent with runc, crun, youki, etc. Several `mount(8)` options such as `X-mount.mode` are unimplemented in those OCI runtimes, and vice versa (`tmpcopyup`, `rro`, etc.) The option table added in this commit conforms to runc 1.1, but `acl` and `noacl` are excluded as the runc implementation seems wrong (runc issue 3738). Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
clarify-mount-options
branch
from
b35b6e2 to
6c638b1
Compare
AkihiroSuda
commented
Feb 10, 2023
| If a custom option string is already recognized by [`mount(8)`][mount.8], the runtime SHOULD follow the behavior of [`mount(8)`][mount.8]. | ||
|
|
||
| Runtimes SHOULD pass unknown options to [`mount(2)`][mount.2] via the fifth argument (`const void *data`). | ||
|
|
Member
Author
There was a problem hiding this comment.
(The list of the implemented options is printed in runc features)
tianon
approved these changes
Feb 10, 2023
Member
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
It's very verbose, but I think that's fair 👍 (and appreciate the clear effort that's gone into making sure it's as terse as it can reasonably be while still being clear)
Member
Author
Thanks, can we merge this too, so that higher-level engines can detect the supported mount options ? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The former wording was inconsistent with runc, crun, youki, etc.
Several
mount(8)options such asX-mount.modeare unimplemented in those OCI runtimes, and vice versa (tmpcopyup,rro, etc.)The option table added in this commit conforms to runc 1.1, but
aclandnoaclare excluded as the runc implementation seems wrong. (runc issue: opencontainers/runc#3738)