config-linux: update type of LinuxCPU.Idle to *int64#1146
Merged
tianon merged 1 commit intoopencontainers:mainfrom Apr 28, 2022
Merged
config-linux: update type of LinuxCPU.Idle to *int64#1146tianon merged 1 commit intoopencontainers:mainfrom
tianon merged 1 commit intoopencontainers:mainfrom
Conversation
wineway
requested review from
crosbymichael,
cyphar,
dqminh,
giuseppe,
hqhq,
mrunalp,
tianon and
vbatts
as code owners
Contributor
Author
|
😂I found this when I try to implement it, if we keep this type, we can only choose a value like |
and add cpu.idle to example in config.md Signed-off-by: wineway <[email protected]>
wineway
changed the title
tianon
approved these changes
Apr 28, 2022
Member
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
LGTM (and matches the description in https://github.com/opencontainers/runtime-spec/blob/2cf6663ca299f8454318ea7c797a8039d013fe8c/config-linux.md#cpu, which IMO doesn't need any updates beyond the OPTIONAL it already has)
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the config values should contain a value that means "do not modify it" within its range of values. for
int64in other cases, we usually use0to express this meaning, but incpu.idle,0can not be regarded as this meaning.by changing the type from
int64to*int64, we can usenilsolve this problem