Update Windows CPU comments#1144
Merged
vbatts merged 1 commit intoopencontainers:mainfrom Apr 20, 2022
Merged
Conversation
jterry75
requested review from
crosbymichael,
cyphar,
dqminh,
giuseppe,
hqhq,
mrunalp,
tianon and
vbatts
as code owners
Contributor
Author
|
@kevpar - FYI |
dcantah
reviewed
Apr 15, 2022
dcantah
approved these changes
Apr 15, 2022
dcantah
left a comment
dcantah
left a comment
There was a problem hiding this comment.
LGTM, one minor comment. Thanks Justin!
Signed-off-by: Justin Terry <[email protected]>
|
LGTM |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the documentation about Windows CPU for containers and the expectations that each of the properties have. This is taken directly from the Microsoft wording at: https://docs.microsoft.com/en-us/virtualization/api/hcs/schemareference#Container_Processor and is also referenced in the markdown for clarity.
Signed-off-by: Justin Terry [email protected]