defs-zos: [Fix] prevent schema parsers from hitting recursion-loop while resolving types.#1117
Merged
giuseppe merged 1 commit intoopencontainers:masterfrom Aug 16, 2021
Merged
Conversation
…ile resolving types. Signed-off-by: flouthoc <[email protected]>
Member
|
@najohnsn could you please take a look? |
Contributor
Author
|
Hi @najohnsn Were you able to take a look at this. |
Contributor
|
Sorry, I was on vacation. This looks good to me. Not sure why a relative reference wasn't used before. |
Member
|
This seems like it's doing the opposite of what https://github.com/opencontainers/runtime-spec/blob/82ab996a5bf91804a440391bff43140b17bbadd4/schema/config-linux.json does? (lots of |
Contributor
|
@tianon, yes, |
Member
|
🤦 doh, thanks for clarifying 👍 |
tianon
approved these changes
Aug 13, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Team,
Following PR makes sure that
des-zos.jsonis consistent with schema definition w.r.t to entire spec.I think following PR ( #1095 ) has introduced type-resolution issues on downstream parsers.
Specifying definition-files for types present in existing
.jsonwould result in infinite type resolution loop. However existing convention is just using#instead of specifying def-file for example https://github.com/opencontainers/runtime-spec/blob/master/schema/defs-linux.jsonThanks