Introduce zos as platform#1095
Conversation
Given that this is speculative, and anything we merge might end up in a release, perhaps this should wait until there's something concrete to include? Alternatively/also, it might be prudent to mark all the bits related to this platform as "experimental" or "in-progress" in some way until it's deemed at least minimally feature complete (if the goal is to merge adjustments incrementally before the full functionality is known/working). |
|
Sorry for the delay. Yes, just as you said, the goal is the merge adjustments incrementally. Let me explain a bit more about /dev on z/OS. Although the major/minor number of devices are different on z/OS when compared to Linux, they can be created in the same way - Do you think that just an in progress note on the |
|
I added a commit to Indicate work in progress. |
tianon
left a comment
There was a problem hiding this comment.
That's good enough for me! 😅 Thanks 👍
LGTM
(Does this mean we're going to get some sweet Z systems to play/CI with?
)
|
IBM is looking at providing z/OS systems for CI. 🙂 It's been a while. Is anything else needed for this PR to get approved/merged? |
|
I'd suggest a rebase (to try and fix the CI failure) and a squash (since I don't think we want three commits that together amount to "this is coming"). 😅 (Maybe that will help encourage other members of @opencontainers/runtime-spec-maintainers to opine/review.) |
specs-go/config.go
Outdated
| // Zos is platform-specific configuration for z/OS based containers. | ||
| Zos *Zos `json:"zos,omitempty" platform:"zos"` |
There was a problem hiding this comment.
In Go, initialisms generally remain capitalized. Seems like the field (and type) should be ZOS instead of Zos.
| // Zos is platform-specific configuration for z/OS based containers. | |
| Zos *Zos `json:"zos,omitempty" platform:"zos"` | |
| // ZOS is platform-specific configuration for z/OS based containers. | |
| ZOS *ZOS `json:"zos,omitempty" platform:"zos"` |
Signed-off-by: Neil Johnson <[email protected]> Signed-off-by: Steele Ray Desmond <[email protected]>
|
@tianon @samuelkarp Thanks for the suggestions! The 3 commits have been replaced by a single commit that incorporates your suggestions. |
samuelkarp
left a comment
There was a problem hiding this comment.
LGTM, though I'm not a maintainer of the spec.
|
Would love to check in on this and see what's the latest status -- this seemed like an effort with a lot of steam behind it three years ago, but we (in the OCI / runtime-spec) haven't really heard anything since. Should we consider removing this temporary/experimental |
|
@tianon, thanks for checking in! Certainly don't want to remove. My team wants to push forward to remove the temporary/experimental status. IBM z/OS Container Platform is available to z/OS customers! We've been waiting for a while for all the pieces to come together, but everything is available now. There are some changes from this initial PR. I believe it mostly amounts to the addition of namespaces on z/OS. I expect that someone on my team will open a PR in the coming weeks. We will want to remove the devices. If it is felt we need to stage that kind of change, we can discuss in the upcoming PR. |
As discussed in the 1/27/2021 OCI developer meeting, these changes introduce IBM z/OS as a Native Platform for OCI. Changes to code, JSON schema, and markdown documentation is included.
Other than
zosbeing added a platform and having its own platform-specific configuration, nothing new is really added with this. The expectation is that additional pull requests (preceded by development discussions, if needed) will be used to request any z/OS-unique configuration properties as the IBM initiative to support OCI containers on z/OS progresses.Note on z/OS devices: it is the only property in the z/OS-specific configuration object. This was copied from how devices can be specified for Linux. Specifying devices like this would be a perfectly valid way to define/create devices in a container on z/OS. However, its usefulness on z/OS is questionable. It is being included in this PR so that something is defined in the z/OS-specific configuration object. It very well may turn out that the ability to specify devices to be created in a z/OS container may be unnecessary and that the definition should be replaced with more useful properties.
Signed-off-by: Neil Johnson [email protected]
Contributors: @SteeleDesmond and @najohnsn