config-linux: Add Intel RDT CMT and MBM Linux support by Creatone · Pull Request #1076 · opencontainers/runtime-spec

Creatone · 2020-11-06T14:26:31Z

Add support for Intel Resource Director Technology (RDT) /
Cache Monitoring Technology (CMT) and Memory Bandwidth Monitoring (MBM).

Example:

"linux": {
    "intelRdt": {
        "enableCMT": true,
        "enableMBM": true
    }
}

This is the prerequisite of this runc proposal:
opencontainers/runc#2519

For more information about Intel RDT CMT and MBM, please refer to:
opencontainers/runc#2519

Signed-off-by: Paweł Szulik [email protected]

Creatone · 2020-11-06T14:27:52Z

@xiaochenshen

config-linux.md

specs-go/config.go

xiaochenshen · 2020-11-06T16:28:35Z

"linux": {
    "intelRdt": {
        "monitoring": true
    }
}

@Creatone
Thank you for adding this to support Intel RDT monitoring features for OCI runtime-spec and runc.
Apart from the nitpicking, this change LGTM.

xiaochenshen

LGTM

caniszczyk · 2020-11-17T16:10:48Z

RFC @opencontainers/runtime-spec-maintainers

…l RDT CMT and MBM Linux support Signed-off-by: Paweł Szulik <[email protected]>

AkihiroSuda · 2020-11-17T17:07:23Z

config-linux.md


    * If `closID` is set, and neither of `l3CacheSchema` and `memBwSchema` are set, runtime MUST check if corresponding pre-configured directory `closID` is present in mounted `resctrl`. If such pre-configured directory `closID` exists, runtime MUST assign container to this `closID` and [generate an error](runtime.md#errors) if directory does not exist.

+* **`monitoring`** *(boolean OPTIONAL)* - specifies if Intel RDT monitoring features (CMT and MBM) should be enabled


Brief description about RDT, CMT, and MBM would be appreciated

Description of IntelRDT is above. Added CMT and MBM information.

…l RDT CMT and MBM Linux support Signed-off-by: Paweł Szulik <[email protected]>

config-linux.md

xiaochenshen · 2020-11-18T00:14:08Z

LGTM (apart from the nitpicking).

xiaochenshen · 2020-11-18T11:12:03Z

LGTM

tianon · 2020-11-24T19:16:51Z

Do you foresee any reason for this to need to be more than just a simple boolean in the future? As an example, can each of the monitoring features mentioned be enabled separately, and is there a use case for doing so?

Creatone · 2020-11-27T10:04:22Z

@tianon Good point. It would be a good thing that the user can choose which features want to use.

xiaochenshen · 2020-11-27T23:42:17Z

Do you foresee any reason for this to need to be more than just a simple boolean in the future? As an example, can each of the monitoring features mentioned be enabled separately, and is there a use case for doing so?

@tianon @Creatone
It makes sense to split Intel RDT monitoring features (CMT and MBM) in config because we could selectively enable/disable Intel RDT sub-features by kernel command line parameter rdt= even though hardware supports both monitoring features. See more details in option rdt= in https://www.kernel.org/doc/Documentation/admin-guide/kernel-parameters.txt

vbatts · 2020-11-30T12:58:18Z

Generally speaking, is this a per container feature? reading the docs looks like it is a kernel global, so does this really only apply for kata-containers that will boot a container/pod into its own kernel that this could apply?

Also, it looks like commit 8f6cf10 has dangling whitespace issues.

xiaochenshen · 2020-11-30T16:09:00Z

Generally speaking, is this a per container feature?

@vbatts Yes, this is a per container feature which depends on Intel RDT kernel support on host.
You could find more details about Intel RDT support for OCI/runc container from:
opencontainers/runc#433
opencontainers/runc#1596
opencontainers/runc#2292

reading the docs looks like it is a kernel global, so does this really only apply for kata-containers that will boot a container/pod into its own kernel that this could apply?

This is not targeted for VM or VM based container (e.g., Kata containers).

vbatts · 2020-12-01T15:24:57Z

gotcha

LGTM

tianon

LGTM

(but I'd love to get at least one more @opencontainers/runtime-spec-maintainers member to take a look 🙏 ❤️)

…l RDT CMT and MBM Linux support Signed-off-by: Paweł Szulik <[email protected]>

specs-go/config.go

config-linux.md

kolyshkin

The commits need to be squashed. It _usually) does not make sense to introduce something and then replace it with something else in the same PR.

Left some minor comments as well. PTAL @Creatone

Creatone · 2021-06-29T13:09:23Z

@kolyshkin PTAL

config-linux.md

kolyshkin · 2021-07-12T02:29:08Z

@Creatone the example in the commit message no longer reflects reality -- please update.

config-linux.md

Add support for Intel Resource Director Technology (RDT) / Cache Monitoring Technology (CMT) and Memory Bandwidth Monitoring (MBM). Example: "linux": { "intelRdt": { "enableCMT": true, "enableMBM": true } } This is the prerequisite of this runc proposal: opencontainers/runc#2519 For more information about Intel RDT CMT and MBM, please refer to: opencontainers/runc#2519 Signed-off-by: Paweł Szulik <[email protected]>

Creatone · 2021-07-13T06:54:47Z

@kolyshkin PTAL

…l RDT CMT and MBM Linux support Signed-off-by: Paweł Szulik <[email protected]>

Creatone · 2021-08-31T18:41:19Z

@caniszczyk @crosbymichael @cyphar @dqminh @giuseppe @hqhq @mrunalp @tianon @vbatts @vishh PTAL, it's waiting from Nov 2020

giuseppe

sorry for the delay.

LGTM

Creatone mentioned this pull request Nov 6, 2020

Add mon groups for resctrl. opencontainers/runc#2523

Open

xiaochenshen suggested changes Nov 6, 2020

View reviewed changes

config-linux.md Outdated Show resolved Hide resolved

xiaochenshen suggested changes Nov 6, 2020

View reviewed changes

specs-go/config.go Outdated Show resolved Hide resolved

xiaochenshen suggested changes Nov 6, 2020

View reviewed changes

specs-go/config.go Outdated Show resolved Hide resolved

xiaochenshen suggested changes Nov 6, 2020

View reviewed changes

specs-go/config.go Outdated Show resolved Hide resolved

Creatone force-pushed the creatone/mon-support branch from 50cfd29 to b8343bc Compare November 7, 2020 15:35

xiaochenshen approved these changes Nov 7, 2020

View reviewed changes

Creatone pushed a commit to Creatone/runc that referenced this pull request Nov 17, 2020

[Dependency: opencontainers/runtime-spec#1076] config-linux: Add Inte…

70683b5

…l RDT CMT and MBM Linux support Signed-off-by: Paweł Szulik <[email protected]>

Creatone pushed a commit to Creatone/runc that referenced this pull request Nov 17, 2020

[Dependency: opencontainers/runtime-spec#1076] config-linux: Add Inte…

196bdef

…l RDT CMT and MBM Linux support Signed-off-by: Paweł Szulik <[email protected]>

AkihiroSuda reviewed Nov 17, 2020

View reviewed changes

Creatone pushed a commit to Creatone/runc that referenced this pull request Nov 17, 2020

[Dependency: opencontainers/runtime-spec#1076] config-linux: Add Inte…

113bea2

…l RDT CMT and MBM Linux support Signed-off-by: Paweł Szulik <[email protected]>

xiaochenshen suggested changes Nov 18, 2020

View reviewed changes

config-linux.md Outdated Show resolved Hide resolved

xiaochenshen suggested changes Nov 18, 2020

View reviewed changes

config-linux.md Outdated Show resolved Hide resolved

Creatone force-pushed the creatone/mon-support branch from 6ad12c8 to ef65e37 Compare November 18, 2020 11:08

Creatone force-pushed the creatone/mon-support branch from ef65e37 to 5175c3e Compare November 24, 2020 08:05

AkihiroSuda approved these changes Nov 24, 2020

View reviewed changes

Creatone force-pushed the creatone/mon-support branch from 8f6cf10 to 9f85c94 Compare November 30, 2020 17:33

tianon approved these changes Dec 1, 2020

View reviewed changes

Creatone pushed a commit to Creatone/runc that referenced this pull request Dec 8, 2020

[Dependency: opencontainers/runtime-spec#1076] config-linux: Add Inte…

eb17229

…l RDT CMT and MBM Linux support Signed-off-by: Paweł Szulik <[email protected]>

Creatone pushed a commit to Creatone/runc that referenced this pull request Dec 28, 2020

[Dependency: opencontainers/runtime-spec#1076] config-linux: Add Inte…

a70b3eb

…l RDT CMT and MBM Linux support Signed-off-by: Paweł Szulik <[email protected]>

caoruidong mentioned this pull request Jan 19, 2021

Proposal: Intel RDT/MBA support for OCI/runc and Docker opencontainers/runc#1596

Open

kolyshkin reviewed Jun 25, 2021

View reviewed changes

specs-go/config.go Outdated Show resolved Hide resolved

kolyshkin reviewed Jun 25, 2021

View reviewed changes

config-linux.md Outdated Show resolved Hide resolved

kolyshkin reviewed Jun 25, 2021

View reviewed changes

config-linux.md Outdated Show resolved Hide resolved

kolyshkin requested changes Jun 25, 2021

View reviewed changes

Creatone force-pushed the creatone/mon-support branch from 9f85c94 to b367dba Compare June 29, 2021 13:08

kolyshkin reviewed Jul 12, 2021

View reviewed changes

config-linux.md Outdated Show resolved Hide resolved

kolyshkin reviewed Jul 12, 2021

View reviewed changes

config-linux.md Outdated Show resolved Hide resolved

Creatone force-pushed the creatone/mon-support branch from b367dba to cc7f6ec Compare July 13, 2021 06:53

Creatone pushed a commit to Creatone/runc that referenced this pull request Jul 13, 2021

[Dependency: opencontainers/runtime-spec#1076] config-linux: Add Inte…

e79e32d

…l RDT CMT and MBM Linux support Signed-off-by: Paweł Szulik <[email protected]>

giuseppe approved these changes Sep 10, 2021

View reviewed changes

vbatts approved these changes Sep 10, 2021

View reviewed changes

vbatts merged commit 0d6cc58 into opencontainers:master Sep 10, 2021

This comment has been minimized.

Sign in to view

utam0k mentioned this pull request Nov 7, 2021

Add Intel RDT CMT and MBM Linux support youki-dev/oci-spec-rs#81

Closed

AkihiroSuda mentioned this pull request Jan 24, 2023

Release v1.1.0-rc.1 #1175

Merged

AkihiroSuda added this to the v1.1.0 milestone Feb 1, 2023

AkihiroSuda mentioned this pull request Jun 26, 2023

Release v1.1.0 #1213

Merged

12 tasks


		* If `closID` is set, and neither of `l3CacheSchema` and `memBwSchema` are set, runtime MUST check if corresponding pre-configured directory `closID` is present in mounted `resctrl`. If such pre-configured directory `closID` exists, runtime MUST assign container to this `closID` and [generate an error](runtime.md#errors) if directory does not exist.

		* `monitoring` (boolean OPTIONAL) - specifies if Intel RDT monitoring features (CMT and MBM) should be enabled

Conversation

Creatone commented Nov 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Creatone commented Nov 6, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xiaochenshen commented Nov 6, 2020

Uh oh!

xiaochenshen left a comment

Choose a reason for hiding this comment

Uh oh!

caniszczyk commented Nov 17, 2020

Uh oh!

AkihiroSuda Nov 17, 2020

Choose a reason for hiding this comment

Uh oh!

Creatone Nov 17, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

xiaochenshen commented Nov 18, 2020

Uh oh!

xiaochenshen commented Nov 18, 2020

Uh oh!

tianon commented Nov 24, 2020

Uh oh!

Creatone commented Nov 27, 2020

Uh oh!

xiaochenshen commented Nov 27, 2020

Uh oh!

vbatts commented Nov 30, 2020

Uh oh!

xiaochenshen commented Nov 30, 2020

Uh oh!

vbatts commented Dec 1, 2020 • edited by caniszczyk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tianon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kolyshkin left a comment

Choose a reason for hiding this comment

Uh oh!

Creatone commented Jun 29, 2021

Uh oh!

Uh oh!

kolyshkin commented Jul 12, 2021

Uh oh!

Uh oh!

Creatone commented Jul 13, 2021

Uh oh!

Creatone commented Aug 31, 2021

Uh oh!

giuseppe left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Creatone commented Nov 6, 2020 •

edited

Loading

vbatts commented Dec 1, 2020 •

edited by caniszczyk

Loading