Yes kernel defines RLIM_INFINITY as unsigned long, we should use the same value otherwise people won't be able to set values larger than MaxInt64 but smaller than MaxUint64. Regarding set to unlimited, since kernel defines RLIM_INFINITY = ~0UL (some architectures might override it), there is no real unlimited value but setting it as a very large one, so users can always set it by themselves, with the fact that:

uint64(-1) = 18446744073709551615
int64(18446744073709551615) = -1

people can still use -1 to set it as unlimited when update as long as we do this forced conversion in runtime before generating the config. In this case, upper level tools need to define this value as int64, but this limitation should be introduced by upper level tools when they see fit, not by spec.

I'm thinking maybe we should revert #648 , types should always be the same as kernel's, we can only change cfs_quota_us as #499 suggested since the kernel type is signed long long and takes -1 as a real unlimited setting.

@crosbymichael @mrunalp @dqminh @tianon WDYT?

How to set rlimit value to unlimited #692

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions