-
Notifications
You must be signed in to change notification settings - Fork 611
Comparing changes
Open a pull request
base repository: opencontainers/runtime-spec
base: v1.0.0-rc6
head repository: opencontainers/runtime-spec
compare: v1.0.0
- 16 commits
- 13 files changed
- 7 contributors
Commits on Jul 6, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 4560f98 - Browse repository at this point
Copy the full SHA 4560f98View commit details
Commits on Jul 7, 2017
-
Merge pull request #884 from tiborvass/omitempty-typo
Fix "omitempty" typo
Configuration menu - View commit details
-
Copy full SHA for 5723c6c - Browse repository at this point
Copy the full SHA 5723c6cView commit details
Commits on Jul 10, 2017
-
defs-linux: add action to to syscalls required
Signed-off-by: zhouhao <[email protected]>
zhouhao committedJul 10, 2017 Configuration menu - View commit details
-
Copy full SHA for 926309e - Browse repository at this point
Copy the full SHA 926309eView commit details -
Signed-off-by: Vincent Batts <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0919a7d - Browse repository at this point
Copy the full SHA 0919a7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c0a3f4 - Browse repository at this point
Copy the full SHA 8c0a3f4View commit details
Commits on Jul 11, 2017
-
Merge pull request #885 from q384566678/action-fix
defs-linux: add action to to syscalls required
Configuration menu - View commit details
-
Copy full SHA for c2c59fa - Browse repository at this point
Copy the full SHA c2c59faView commit details -
ROADMAP: remove the pre-v1.0.0 roadmap
This is not stopping a future roadmap, only removing the one for pre-v1.0.0 Signed-off-by: Vincent Batts <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6a22705 - Browse repository at this point
Copy the full SHA 6a22705View commit details -
Merge pull request #890 from vbatts/remove_roadmap
ROADMAP: remove the pre-v1.0.0 roadmap
Configuration menu - View commit details
-
Copy full SHA for a39b1cd - Browse repository at this point
Copy the full SHA a39b1cdView commit details -
ChangeLog: Document changes since c83b8c8
Through f4d221c (Merge pull request #880 from dqminh/wking-linux-only-capabilities-again, 2017-07-05). The rc6 release picked up an earlier version of these notes, and those entries are mostly unchanged except for: * The credentialSpec entry, which was #814 for credentialspec and now also includes #859 for credentialSpec. * The root(.path) Hyper-V entry, which was #820 for root.path and now also includes #838 for root. I also moved this into the "breaking changes" section, because rc5 Hyper-V configs required root to be set, and rc6 Hyper-V configs require it to not be set. Although whether rc5 allowed Hyper-V configs at all is not clear to me. * Fixed indenting for the typo-fixes entry, as well as a number of more recent typo-fix PRs. Signed-off-by: W. Trevor King <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 913d300 - Browse repository at this point
Copy the full SHA 913d300View commit details
Commits on Jul 12, 2017
-
Merge pull request #888 from wking/v1.0.0-rc6-change-log
ChangeLog: Document changes since c83b8c8
Configuration menu - View commit details
-
Copy full SHA for 06c488c - Browse repository at this point
Copy the full SHA 06c488cView commit details -
config-linux: Move 'disableOOMKiller' under 'memory'
It's backed by memory.oom_control, so this commit moves it in with the rest of the memory-controller config. Looking at the history, the initial request landing a setting for this in the Docker/OCI ecosystem seems to be [1], which added Cgroup.OomKillDisable. That commit was carried from libcontainer into runC [2] where it is now Resources.OomKillDisable [3]. From runC it was carried into this repo (with some renaming) in [4]. Subsequent early doc updates landed in [5,6]. In none of those can I find discussion about why the setting is not already under memory. I expect the reason is that the runC structures are flat, so "under memory" is not a thing there. But in this spec, resources has per-controller sub-properties. The fact that disableOOMKiller belonged to the memory controller may have been overlooked in [4] and never revisited until now. [1]: docker-archive/libcontainer#417 Subject: cgroups: add support for oom control [2]: opencontainers/runc@295c708 Subject: cgroups: add support for oom control [3]: https://github.com/opencontainers/runc/blob/v1.0.0-rc3/libcontainer/configs/cgroup_unix.go#L113-L114 [4]: #51 Subject: Add Go types for specification [5]: #137 Subject: Adding cgroups path to the Spec. [6]: #199 Subject: runtime: config: linux: add cgroups informations Signed-off-by: W. Trevor King <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ef51409 - Browse repository at this point
Copy the full SHA ef51409View commit details -
Merge pull request #896 from wking/disable-oom-killer-under-memory
config-linux: Move 'disableOOMKiller' under 'memory'
Mrunal Patel authoredJul 12, 2017 Configuration menu - View commit details
-
Copy full SHA for a7bc89b - Browse repository at this point
Copy the full SHA a7bc89bView commit details -
Make pid option on platforms other than linux
Signed-off-by: Michael Crosby <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d3c8849 - Browse repository at this point
Copy the full SHA d3c8849View commit details -
Merge pull request #897 from crosbymichael/pids
Make pid option on platforms other than linux
Configuration menu - View commit details
-
Copy full SHA for 96de01b - Browse repository at this point
Copy the full SHA 96de01bView commit details -
ChangeLog: Document changes since v1.0.0-rc6
Through 96de01b (Merge pull request #897 from crosbymichael/pids, 2017-07-12). Signed-off-by: W. Trevor King <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for eac58a4 - Browse repository at this point
Copy the full SHA eac58a4View commit details -
Signed-off-by: Vincent Batts <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 02137cd - Browse repository at this point
Copy the full SHA 02137cdView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.0.0-rc6...v1.0.0