Skip to content

Commit 330223b

Browse files
committed
runtime-config: Require serial hook execution
Extend [1,2,3] to avoid: hook 1: spawn ---------------> reaped hook 2: spawn ----------------> reaped hook 3: spawn -----> reaped and explicitly require: hook 1: spawn --> reaped hook 2: spawn --> reaped hook 3: spawn --> reaped Folks who do want parallel execution are free to use a parallelizing wrapper: hook 1: spawn ---------------------------> reaped child 1 -----> reaped child 2 ---------> reaped child 3 ---> reaped Although that cuts both ways (with parallel hooks, folks could always use a single hook with a serializing wrapper). Still, I'd guess most current implementations are already taking the serialized approach, so it makes bundle-author life easier if we are explicit about that. [1]: #20 (comment) [2]: #156 [3]: #157 Signed-off-by: W. Trevor King <[email protected]>
1 parent 772f073 commit 330223b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

runtime-config.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Presently there are `Prestart`, `Poststart` and `Poststop`.
1010
* [`Poststop`](#poststop) is a list of hooks to be run after the container process exits
1111

1212
Hooks allow one to run code before/after various lifecycle events of the container.
13-
Hooks MUST be called in the listed order.
13+
Hooks MUST be called in the listed order, with each hook process being reaped before the next hook is executed.
1414
The state of the container is passed to the hooks over stdin, so the hooks could get the information they need to do their work.
1515

1616
Hook paths are absolute and are executed from the host's filesystem.

0 commit comments

Comments
 (0)