[1.2] libct: fix mips compilation#4965
Merged
lifubang merged 1 commit intoopencontainers:release-1.2from Nov 6, 2025
Merged
Conversation
On MIPS arches, Rdev is uint32 so we have to convert it. Fixes issue 4962. Fixes: 8476df8 ("libct: add/use isDevNull, verifyDevNull") Fixes: de87203 ("console: verify /dev/pts/ptmx before use") Fixes: 398955b ("console: add fallback for pre-TIOCGPTPEER kernels") Reported-by: Tianon Gravi <[email protected]> Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit 1b954f1) Signed-off-by: Aleksa Sarai <[email protected]>
AkihiroSuda
approved these changes
Nov 6, 2025
lifubang
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4964.
On MIPS arches, Rdev is uint32 so we have to convert it.
Can't test this for mips in CI (adding mips compile which is not easy as distros drop mips support).
Tested locally with:
(which still errors out but it's not related).
Fixes: #4962.
Fixes: 8476df8 ("libct: add/use isDevNull, verifyDevNull")
Fixes: de87203 ("console: verify /dev/pts/ptmx before use")
Fixes: 398955b ("console: add fallback for pre-TIOCGPTPEER kernels")
Reported-by: @tianon