skip non-existant volume host path#492
Closed
keloyang wants to merge 1 commit intoopencontainers:masterfrom
keloyang:skip-non-existant-volume
Closed
skip non-existant volume host path#492keloyang wants to merge 1 commit intoopencontainers:masterfrom keloyang:skip-non-existant-volume
keloyang wants to merge 1 commit intoopencontainers:masterfrom
keloyang:skip-non-existant-volume
Conversation
libcontainer/rootfs_linux.go
Outdated
Contributor
There was a problem hiding this comment.
this fmt.Print is going to be noisy to anyone importing this pkg
Signed-off-by: yangshukui <[email protected]>
Member
|
I don't think this is the level to do this type of change to, if the source does not exist for the mount then there is nothing that libcontainer can do about it and it should fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently, docker create non-existent volume host path automatically.see the code of docker
e.g.
if the /hello dir don't exist in host, docker will create it to avoid the fail of mount.
But it is not reasonable.in fact,we can skip non-existant volume host path and remove "MkdirAll" from Setup.
Signed-off-by: yangshukui [email protected]