[1.3] tests/int/cgroups: Use 64K aligned limits for memory.max#4895
Merged
rata merged 1 commit intoopencontainers:release-1.3from Sep 18, 2025
Merged
[1.3] tests/int/cgroups: Use 64K aligned limits for memory.max#4895rata merged 1 commit intoopencontainers:release-1.3from
rata merged 1 commit intoopencontainers:release-1.3from
Conversation
When a non–page-aligned value is written to memory.max, the kernel aligns it down to the nearest page boundary. On systems with a page size greater than 4K (e.g., 64K), this caused failures because the configured memory.max value was not 64K aligned. This patch fixes the issue by explicitly aligning the memory.max value to 64K. Since 64K is also a multiple of 4K, the value is correctly aligned on both 4K and 64K page size systems. However, this approach will still fail on systems where the hardcoded memory.max value is not aligned to the system page size. Fixes: opencontainers#4841 Signed-off-by: Vishal Chourasia <[email protected]> Signed-off-by: Donet Tom <[email protected]> (cherry picked from commit 830c479) Signed-off-by: Rodrigo Campos <[email protected]>
rata
changed the title
cyphar
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4893 to v1.3
When a non–page-aligned value is written to memory.max, the kernel aligns it down to the nearest page boundary. On systems with a page size greater than 4K (e.g., 64K), this caused failures because the configured memory.max value was not 64K aligned.
This patch fixes the issue by explicitly aligning the memory.max value to 64K. Since 64K is also a multiple of 4K, the value is correctly aligned on both 4K and 64K page size systems.
However, this approach will still fail on systems where the hardcoded memory.max value is not aligned to the system page size.
Fixes: #4841
(cherry picked from commit 830c479)