libcontainer/userns: migrate to github.com/moby/sys/userns#4350
Merged
cyphar merged 1 commit intoopencontainers:mainfrom Oct 9, 2024
Merged
libcontainer/userns: migrate to github.com/moby/sys/userns#4350cyphar merged 1 commit intoopencontainers:mainfrom
cyphar merged 1 commit intoopencontainers:mainfrom
Conversation
This was referenced Jul 16, 2024
Merged
thaJeztah
force-pushed
the
migrate_userns
branch
from
cfb8cb4 to
8854ad2
Compare
thaJeztah
force-pushed
the
migrate_userns
branch
from
8854ad2 to
3d0a6e5
Compare
thaJeztah
changed the title
thaJeztah
force-pushed
the
migrate_userns
branch
from
3d0a6e5 to
a241e83
Compare
AkihiroSuda
reviewed
Aug 31, 2024
| @@ -1,8 +1,13 @@ | |||
| // Deprecated: use github.com/moby/sys/userns | |||
Member
There was a problem hiding this comment.
Can we just remove libct/userns ?
Member
There was a problem hiding this comment.
I think the concern is downstream users that import github.com/opencontainers/runc/libcontainer/userns. It seems there are a fair number of places that import this package unfortunately (though it seems they're mostly kubelet and kubelet forks and buildah?).
Member
Author
There was a problem hiding this comment.
Yes, correct; mostly to give potential users of this a warning that they should use the separate module instead. We can decide how long to keep the alias in place (although it doesn't give a significant amount of maintenance)
AkihiroSuda
approved these changes
Aug 31, 2024
19 tasks
lifubang
approved these changes
Oct 9, 2024
The userns package was moved to the moby/sys/userns module at commit 3778ae6. This patch deprecates the old location, and adds it as an alias for the moby/sys/userns package. Signed-off-by: Sebastiaan van Stijn <[email protected]>
lifubang
force-pushed
the
migrate_userns
branch
from
a241e83 to
9b60a93
Compare
Member
Author
|
@kolyshkin @cyphar this one good to go? |
kolyshkin
reviewed
Oct 21, 2024
kolyshkin
added a commit
to kolyshkin/kubernetes
that referenced
this pull request
Oct 21, 2024
The code from github.com/opencontainers/runc/libcontainer/userns package was moved into github.com/moby/sys/user and github.com/moby/sys/userns (see [1]), and the runc package is now deprecated in favor of moby/sys (see [2]). In addition, moby/sys/userns now has a non-Linux implementation, so pkg/kubelet/user/userns package (introduced in commit 2e999ff to make a non-Linux implementation) is not really needed anymore. Let's switch to moby/sys/userns, and remove the package. [1]: https://github.com/moby/sys/releases/tag/userns%2Fv0.1.0 [2]: opencontainers/runc#4350 Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
added a commit
to kolyshkin/kubernetes
that referenced
this pull request
Oct 22, 2024
The code from github.com/opencontainers/runc/libcontainer/userns package was moved into github.com/moby/sys/user and github.com/moby/sys/userns (see [1]), and the runc package is now deprecated in favor of moby/sys (see [2]). In addition, moby/sys/userns now has a non-Linux implementation, so pkg/kubelet/user/userns package (introduced in commit 2e999ff to make a non-Linux implementation) is not really needed anymore. Let's switch to moby/sys/userns, and remove the package. [1]: https://github.com/moby/sys/releases/tag/userns%2Fv0.1.0 [2]: opencontainers/runc#4350 Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
added a commit
to kolyshkin/kubernetes
that referenced
this pull request
Oct 22, 2024
The code from github.com/opencontainers/runc/libcontainer/userns package was moved into github.com/moby/sys/user and github.com/moby/sys/userns (see [1]), and the runc package is now deprecated in favor of moby/sys (see [2]). In addition, moby/sys/userns now has a non-Linux implementation, so pkg/kubelet/user/userns package (introduced in commit 2e999ff to make a non-Linux implementation) is not really needed anymore. Let's switch to moby/sys/userns, and remove the package. [1]: https://github.com/moby/sys/releases/tag/userns%2Fv0.1.0 [2]: opencontainers/runc#4350 Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
added a commit
to kolyshkin/kubernetes
that referenced
this pull request
Oct 23, 2024
The code from github.com/opencontainers/runc/libcontainer/userns package was moved into github.com/moby/sys/user and github.com/moby/sys/userns (see [1]), and the runc package is now deprecated in favor of moby/sys (see [2]). In addition, moby/sys/userns now has a non-Linux implementation, so pkg/kubelet/user/userns package (introduced in commit 2e999ff to make a non-Linux implementation) is not really needed anymore. Let's switch to moby/sys/userns, and remove the package. [1]: https://github.com/moby/sys/releases/tag/userns%2Fv0.1.0 [2]: opencontainers/runc#4350 Signed-off-by: Kir Kolyshkin <[email protected]>
scott-grimes
pushed a commit
to scott-grimes/kubernetes
that referenced
this pull request
Oct 23, 2024
The code from github.com/opencontainers/runc/libcontainer/userns package was moved into github.com/moby/sys/user and github.com/moby/sys/userns (see [1]), and the runc package is now deprecated in favor of moby/sys (see [2]). In addition, moby/sys/userns now has a non-Linux implementation, so pkg/kubelet/user/userns package (introduced in commit 2e999ff to make a non-Linux implementation) is not really needed anymore. Let's switch to moby/sys/userns, and remove the package. [1]: https://github.com/moby/sys/releases/tag/userns%2Fv0.1.0 [2]: opencontainers/runc#4350 Signed-off-by: Kir Kolyshkin <[email protected]>
richabanker
pushed a commit
to richabanker/kubernetes
that referenced
this pull request
Oct 29, 2024
The code from github.com/opencontainers/runc/libcontainer/userns package was moved into github.com/moby/sys/user and github.com/moby/sys/userns (see [1]), and the runc package is now deprecated in favor of moby/sys (see [2]). In addition, moby/sys/userns now has a non-Linux implementation, so pkg/kubelet/user/userns package (introduced in commit 2e999ff to make a non-Linux implementation) is not really needed anymore. Let's switch to moby/sys/userns, and remove the package. [1]: https://github.com/moby/sys/releases/tag/userns%2Fv0.1.0 [2]: opencontainers/runc#4350 Signed-off-by: Kir Kolyshkin <[email protected]>
felipeagger
pushed a commit
to felipeagger/kubernetes
that referenced
this pull request
Nov 6, 2024
The code from github.com/opencontainers/runc/libcontainer/userns package was moved into github.com/moby/sys/user and github.com/moby/sys/userns (see [1]), and the runc package is now deprecated in favor of moby/sys (see [2]). In addition, moby/sys/userns now has a non-Linux implementation, so pkg/kubelet/user/userns package (introduced in commit 2e999ff to make a non-Linux implementation) is not really needed anymore. Let's switch to moby/sys/userns, and remove the package. [1]: https://github.com/moby/sys/releases/tag/userns%2Fv0.1.0 [2]: opencontainers/runc#4350 Signed-off-by: Kir Kolyshkin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal#3028The userns package was moved to moby/sys/userns module at commit 3778ae6.
This patch deprecates the old location, and adds it as an alias for the moby/sys/userns package.