[1.1] fix a debug msg for user ns in nsexec#4315
Merged
kolyshkin merged 1 commit intoopencontainers:release-1.1from Jun 11, 2024
Merged
[1.1] fix a debug msg for user ns in nsexec#4315kolyshkin merged 1 commit intoopencontainers:release-1.1from
kolyshkin merged 1 commit intoopencontainers:release-1.1from
Conversation
Signed-off-by: lfbzhm <[email protected]> (cherry picked from commit 24c2d28) Signed-off-by: lifubang <[email protected]>
Merged
AkihiroSuda
approved these changes
Jun 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #4311 to release-1.1 branch.
When I was using
runc --debugto run a container with user ns, I saw two debug msgsrequest stage-0 to map user namespace, it would make users confused.At the first I thought runc requested stage-0 two times to map user ns? But after looked into the code, there are two same debug msgs in nsexec:
https://github.com/opencontainers/runc/blob/6b9b2c3d/libcontainer/nsenter/nsexec.c#L899
(cherry picked from commit 24c2d28)