Stop blacklisting Go 1.22+, drop Go < 1.21 support, use Go 1.22 in CI by kolyshkin · Pull Request #4292 · opencontainers/runc

kolyshkin · 2024-05-25T00:04:56Z

High level overview:

remove nsenter compile restriction since Go 1.22.4 and Go 1.23 can now be used. THIS PART NEEDS TO BE BACKPORTED TO 1.1.
switch to Go 1.22 in CI whether possible (everywhere except Ubuntu 20.04 and CentOS 7 and 8).
set minimum requirement to Go 1.21
rm some old code.

See individual commits for details.

rata

LGTM, thanks!

It took me a while to test locally that the go version dance was fine, but it indeed seem fine :)

btw, it seems the ubuntu builds are stalled.

README.md

Makefile

kolyshkin · 2024-06-01T20:15:04Z

We'll probably need to port the first 3 patches to release-1.1 (so that it will work with Go 1.22).

kolyshkin · 2024-06-02T18:12:03Z

btw, it seems the ubuntu builds are stalled.

This PR drops go 1.20.x tests, but they are marked as required in repo config -- this is why they are shown as "Expected -- waiting ...". I will fix the repo config accordingly (rm go 1.20.x, require go 1.22.x) once this PR will be ready to be merged (I guess once Go 1.21.4 is out).

kolyshkin · 2024-06-02T18:12:23Z

@opencontainers/runc-maintainers wdyt?

.github/workflows/test.yml

AkihiroSuda · 2024-06-02T18:44:28Z

README.md

 ## Building

-`runc` only supports Linux. It must be built with Go version 1.19 or higher.
+`runc` only supports Linux. It must be built with Go version 1.21 or higher.


Maybe add some note about Go 1.22

I had this originally but got it removed as explained above: #4292 (comment) (TL;DR: the error message is explanatory enough).

rata

LGTM, one minor (optional) nit. Very optional, as that code will cease to exist in a few months :)

Makefile

kolyshkin · 2024-06-03T18:32:21Z

@lifubang @cyphar PTAL

AkihiroSuda · 2024-06-03T18:46:26Z

CentOS tests seem failing

thaJeztah · 2024-06-03T19:51:04Z

CentOS tests seem failing

For CentOS stream 8, that may be expected; it's EOL since May 31 (just got hit by that in some CI pipeline that als had it in the Matrix)

AkihiroSuda · 2024-06-03T20:41:44Z

CentOS tests seem failing

For CentOS stream 8, that may be expected; it's EOL since May 31 (just got hit by that in some CI pipeline that als had it in the Matrix)

I guess we now have to replace CentOS with Alma, Rocky, or Oracle Linux?

lifubang · 2024-06-04T10:10:16Z

This one should be merged after go 1.22.4 has released.

rata

LGTM

README.md

Go 1.23 includes a fix (https://go.dev/cl/587919) so go1.23.x can be used. This fix is also backported to 1.22.4, so go1.22.x can also be used (when x >= 4). Finally, for glibc >= 2.32 it doesn't really matter. Add a note about Go 1.22.x > 1.22.4 to README as well. Signed-off-by: Kir Kolyshkin <[email protected]>

Now when Go 1.22.4 is out it should no longer be a problem. Leave Go 1.21 for CentOS testing (CentOS 7 and 8 have older glibc) and Dockerfile (Debian 11 have older glibc). Signed-off-by: Kir Kolyshkin <[email protected]>

Signed-off-by: Kir Kolyshkin <[email protected]>

Go 1.20 was released in February 2023 and is no longer supported since February 2024. Time to move on. Signed-off-by: Kir Kolyshkin <[email protected]>

It is not needed since Go 1.20 (which was released in February 2023 and is no longer supported since February 2024). Signed-off-by: Kir Kolyshkin <[email protected]>

As we're no longer supporting Go < 1.21. Signed-off-by: Kir Kolyshkin <[email protected]>

As we no longer support Go < 1.21. Signed-off-by: Kir Kolyshkin <[email protected]>

kolyshkin · 2024-06-07T17:24:19Z

Assuming that by the time 1.2.0 is out, everyone will use Go 1.22.x >= 1.22.4, I just dropped the restriction (and added a note to README).

I think this is ready to be merged. WDYT @cyphar?

README.md

kolyshkin force-pushed the go122 branch 4 times, most recently from c20f7e5 to 6b132ac Compare May 30, 2024 22:28

kolyshkin marked this pull request as ready for review May 30, 2024 23:10

rata approved these changes May 31, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

kolyshkin force-pushed the go122 branch from 6b132ac to 7d2e5e9 Compare June 1, 2024 06:20

kolyshkin requested review from AkihiroSuda, cyphar and lifubang June 1, 2024 06:21

AkihiroSuda reviewed Jun 1, 2024

View reviewed changes

Makefile Outdated Show resolved Hide resolved

kolyshkin force-pushed the go122 branch from 7d2e5e9 to 69c4c0b Compare June 1, 2024 20:13

kolyshkin requested a review from AkihiroSuda June 1, 2024 20:14

kolyshkin added the backport/1.1-todo A PR in main branch which needs to be backported to release-1.1 label Jun 1, 2024

AkihiroSuda reviewed Jun 2, 2024

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

AkihiroSuda reviewed Jun 2, 2024

View reviewed changes

AkihiroSuda approved these changes Jun 2, 2024

View reviewed changes

rata approved these changes Jun 3, 2024

View reviewed changes

Makefile Outdated Show resolved Hide resolved

kolyshkin force-pushed the go122 branch from 69c4c0b to 11d9181 Compare June 3, 2024 18:31

AkihiroSuda approved these changes Jun 3, 2024

View reviewed changes

AkihiroSuda mentioned this pull request Jun 3, 2024

CI: Replace CentOS Stream 8 with Alma, Rocky, or Oracle Linux due to EOL #4302

Closed

mrunalp approved these changes Jun 3, 2024

View reviewed changes

kolyshkin force-pushed the go122 branch 5 times, most recently from b72e13a to 1600312 Compare June 6, 2024 21:33

tgross mentioned this pull request Jun 7, 2024

read init-p: connection reset by peer hashicorp/nomad#20212

Closed

lifubang mentioned this pull request Jun 7, 2024

let runc work with glibc lt 2.32 in go 1.22.x #4310

Closed

kolyshkin force-pushed the go122 branch from 1600312 to b364d1a Compare June 7, 2024 16:15

rata approved these changes Jun 7, 2024

View reviewed changes

rata reviewed Jun 7, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

kolyshkin changed the title ~~Drop Go < 1.21 support, use Go 1.22 in CI, relax go122+glibc check~~ Stop blacklisting Go 1.22+, drop Go < 1.21 support, use Go 1.22 in CI Jun 7, 2024

kolyshkin added 7 commits June 7, 2024 10:18

ci: switch to go 1.22 as main version

a3302f2

Now when Go 1.22.4 is out it should no longer be a problem. Leave Go 1.21 for CentOS testing (CentOS 7 and 8 have older glibc) and Dockerfile (Debian 11 have older glibc). Signed-off-by: Kir Kolyshkin <[email protected]>

Dockerfile: switch to Go 1.22 and Debian 12

17380da

Signed-off-by: Kir Kolyshkin <[email protected]>

go.mod,README: require Go 1.21

6b2eb52

Go 1.20 was released in February 2023 and is no longer supported since February 2024. Time to move on. Signed-off-by: Kir Kolyshkin <[email protected]>

libct: rm eaccess

a1e87f8

It is not needed since Go 1.20 (which was released in February 2023 and is no longer supported since February 2024). Signed-off-by: Kir Kolyshkin <[email protected]>

libct: use slices package

b7fdd52

As we're no longer supporting Go < 1.21. Signed-off-by: Kir Kolyshkin <[email protected]>

libct/cg: use clear built-in

3019e84

As we no longer support Go < 1.21. Signed-off-by: Kir Kolyshkin <[email protected]>

kolyshkin force-pushed the go122 branch from b364d1a to 3019e84 Compare June 7, 2024 17:20

kolyshkin mentioned this pull request Jun 7, 2024

[1.1] Support Go 1.22, bump some CI deps #4313

Merged

kolyshkin added backport/1.1-done A PR in main branch which has been backported to release-1.1 and removed backport/1.1-todo A PR in main branch which needs to be backported to release-1.1 labels Jun 7, 2024

lifubang reviewed Jun 7, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

lifubang approved these changes Jun 7, 2024

View reviewed changes

AkihiroSuda approved these changes Jun 8, 2024

View reviewed changes

AkihiroSuda merged commit 865224d into opencontainers:main Jun 8, 2024

AkihiroSuda mentioned this pull request Jun 8, 2024

runc doesn't work with go1.22 #4233

Closed

lifubang mentioned this pull request Jun 10, 2024

Release 1.2.0-rc.2 #4317

Merged

akhilerm mentioned this pull request Aug 3, 2024

kubectl unable to terminate pod -- runc exit with error code 1 containerd/containerd#10542

Closed

Conversation

kolyshkin commented May 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rata left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kolyshkin commented Jun 1, 2024

Uh oh!

kolyshkin commented Jun 2, 2024

Uh oh!

kolyshkin commented Jun 2, 2024

Uh oh!

Uh oh!

AkihiroSuda Jun 2, 2024

Choose a reason for hiding this comment

Uh oh!

kolyshkin Jun 3, 2024

Choose a reason for hiding this comment

Uh oh!

rata left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kolyshkin commented Jun 3, 2024

Uh oh!

AkihiroSuda commented Jun 3, 2024

Uh oh!

thaJeztah commented Jun 3, 2024

Uh oh!

AkihiroSuda commented Jun 3, 2024

Uh oh!

lifubang commented Jun 4, 2024

Uh oh!

rata left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kolyshkin commented Jun 7, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kolyshkin commented May 25, 2024 •

edited

Loading

rata left a comment •

edited

Loading

rata left a comment •

edited

Loading