Skip to content

CI: add actuated-arm64#4142

Merged
lifubang merged 5 commits intoopencontainers:mainfrom
AkihiroSuda:actuated
Apr 24, 2024
Merged

CI: add actuated-arm64#4142
lifubang merged 5 commits intoopencontainers:mainfrom
AkihiroSuda:actuated

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda commented Dec 12, 2023 •
edited
Loading

See https://actuated.dev/blog/arm-ci-cncf-ampere.
Thanks to Alex Ellis, Ampere Computing, and Equinix.

Host information:

  • CPU: aarch64 (ARMv8)
  • Kernel: 5.10.201
    • Lacks CONFIG_CHECKPOINT_RESTORE, CONFIG_BLK_CGROUP_IOCOST, etc.
  • Cgroup: v2
  • OS: Ubuntu 22.04
    • Lacks newuidmap, newgidmap, etc. (still apt-gettable)
    • sshd is not running

@AkihiroSuda AkihiroSuda marked this pull request as draft December 12, 2023 11:14
AkihiroSuda
AkihiroSuda commented Dec 12, 2023
View reviewed changes
@AkihiroSuda
Copy link
Copy Markdown
Member Author

AkihiroSuda commented Dec 12, 2023

cc @alexellis @vielmetti

@alexellis
Copy link
Copy Markdown

alexellis commented Dec 14, 2023

Thanks for the ping. The build should run once the GitHub app is installed.

@alexellis
Copy link
Copy Markdown

alexellis commented Dec 14, 2023

Thanks to @amye the app is now installed.

@AkihiroSuda AkihiroSuda force-pushed the actuated branch 23 times, most recently from 715693c to c844665 Compare December 15, 2023 08:33
@AkihiroSuda AkihiroSuda mentioned this pull request Mar 4, 2024
Merged
This was referenced Mar 18, 2024
Open
Closed
@AkihiroSuda
Copy link
Copy Markdown
Member Author

AkihiroSuda commented Apr 10, 2024

Rebased.
I guess the criu stuff can be revisited in a separate PR later.

@alexellis
Copy link
Copy Markdown

alexellis commented Apr 10, 2024

We have a 6.x Kernel on the roadmap, but it's a significant amount of labour and iteration to take a Firecracker guest Kernel and only enable the specific features for containers and ebpf, so if that resolves the issues with CRIU we will reach out when it's ready.

I'd suggest you merge this PR and skip those tests for the time being on arm64. The project's test coverage on native hardware will be in a much better position already. Would you agree?

@AkihiroSuda
Copy link
Copy Markdown
Member Author

AkihiroSuda commented Apr 22, 2024

Ping @opencontainers/runc-maintainers
Let's merge this

kolyshkin
kolyshkin reviewed Apr 23, 2024
View reviewed changes
kolyshkin
kolyshkin approved these changes Apr 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just one minor nit

@AkihiroSuda
CI: run apt with -y
30dc98f 
Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda
seccomp_syscall_test1: use ftruncate instead of kcmp
053f6a0 
kcmp is often missing: https://man7.org/linux/man-pages/man2/kcmp.2.html

> Before Linux 5.12, this system call is available only if the
> kernel is configured with CONFIG_CHECKPOINT_RESTORE, since the
> original purpose of the system call was for the
> checkpoint/restore in user space (CRIU) feature.  (The
> alternative to this system call would have been to expose
> suitable process information via the proc(5) filesystem; this was
> deemed to be unsuitable for security reasons.)  Since Linux 5.12,
> this system call is also available if the kernel is configured
> with CONFIG_KCMP.

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda
cgroups.bats: check cgroups_io_weight
d618c6f 
Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda
helpers.bats: cgroups_cpu_burst: check kernel version
758b2e2 
On cgroup v2, cpu burst needs kernel >= 5.14
torvalds/linux@f418371

Signed-off-by: Akihiro Suda <[email protected]>
lifubang
lifubang reviewed Apr 23, 2024
View reviewed changes
lifubang
lifubang reviewed Apr 23, 2024
View reviewed changes
lifubang
lifubang reviewed Apr 23, 2024
View reviewed changes
kolyshkin
kolyshkin reviewed Apr 24, 2024
View reviewed changes
kolyshkin
kolyshkin reviewed Apr 24, 2024
View reviewed changes
@AkihiroSuda
CI: add actuated-arm64
00238f5 
See <https://actuated.dev/blog/arm-ci-cncf-ampere>.
Thanks to Alex Ellis, Ampere Computing, and Equinix.

Host information:
* CPU: aarch64 (ARMv8)
* Kernel: 5.10.201
  * Lacks ~CONFIG_CHECKPOINT_RESTORE~, CONFIG_BLK_CGROUP_IOCOST, etc.
* Cgroup: v2
* OS: Ubuntu 22.04
  * Lacks newuidmap, newgidmap, etc. (still apt-gettable)
  * sshd is not running

vmmeter is added from:
https://gist.github.com/alexellis/1f33e581c75e11e161fe613c46180771#file-metering-gha-md

Signed-off-by: Akihiro Suda <[email protected]>
@lifubang lifubang merged commit 52bd9fd into opencontainers:main Apr 24, 2024
@lifubang
Copy link
Copy Markdown
Member

lifubang commented Apr 24, 2024

Thanks @alexellis

This was referenced Apr 25, 2024
Merged
Merged
@alexellis
Copy link
Copy Markdown

alexellis commented Apr 25, 2024

You're welcome.

@kolyshkin kolyshkin mentioned this pull request May 9, 2024
Closed
@lifubang lifubang mentioned this pull request Jun 10, 2024
Merged
@thaJeztah thaJeztah mentioned this pull request Feb 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kolyshkin kolyshkin kolyshkin approved these changes

@lifubang lifubang lifubang approved these changes

@cyphar cyphar Awaiting requested review from cyphar

+2 more reviewers

@amye amye amye left review comments

@alexellis alexellis alexellis left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@AkihiroSuda @alexellis @kolyshkin @adrianreber @lifubang @amye @cyphar